Make listdirs(hidden=True) the default uniformly.

This was the case for all but OSFS and ZipFS, and it meant that copydir()
would not copy hidden files.  If this default isn't desired, walk() needs
to grow a hidden=True argument and copydir() needs to use it.

fs/base.py

@@ -802,4 +802,4 @@ if __name__ == "__main__":
 
 
     #browsewin.browse(fs1)
-    browsewin.browse(fs2)
\ No newline at end of file
+    browsewin.browse(fs2)

fs/osfs.py

@@ -56,7 +56,7 @@ class OSFS(FS):
     def ishidden(self, path):
         return path.startswith('.')
 
-    def listdir(self, path="./", wildcard=None, full=False, absolute=False, hidden=False, dirs_only=False, files_only=False):
+    def listdir(self, path="./", wildcard=None, full=False, absolute=False, hidden=True, dirs_only=False, files_only=False):
         try:
             paths = os.listdir(self.getsyspath(path))
         except (OSError, IOError), e:
@@ -198,4 +198,4 @@ if __name__ == "__main__":
 
     print pathjoin('/', 'a')
 
-    print pathjoin('a/b/c', '../../e/f')
\ No newline at end of file
+    print pathjoin('a/b/c', '../../e/f')

fs/tests.py

@@ -247,6 +247,7 @@ class TestOSFS(unittest.TestCase):
         self.assert_(check("foo.txt"))
         self.fs.rename("foo.txt", "bar.txt")
         self.assert_(check("bar.txt"))
+        self.assert_(not check("foo.txt"))
 
     def test_info(self):
         test_str = "Hello, World!"
@@ -276,6 +277,7 @@ class TestOSFS(unittest.TestCase):
             f = self.fs.open(path, "rb")
             check_contents = f.read()
             f.close()
+            self.assertEqual(check_contents,contents)
             return contents == check_contents
 
         self.fs.makedir("foo/bar", recursive=True)
@@ -354,6 +356,28 @@ class TestOSFS(unittest.TestCase):
         self.assert_(check("a/3.txt"))
         self.assert_(check("a/foo/bar/baz.txt"))
 
+    def test_copydir_with_hidden(self):
+        check = self.check
+        contents = "If the implementation is hard to explain, it's a bad idea."
+        def makefile(path):
+            f = self.fs.open(path, "wb")
+            f.write(contents)
+            f.close()
+
+        self.fs.makedir("a")
+        makefile("a/1.txt")
+        makefile("a/2.txt")
+        makefile("a/.hidden.txt")
+
+        self.fs.makedir("copy of a")
+        self.fs.copydir("a", "copy of a")
+        self.assert_(check("copy of a/1.txt"))
+        self.assert_(check("copy of a/2.txt"))
+        self.assert_(check("copy of a/.hidden.txt"))
+
+        self.assert_(check("a/1.txt"))
+        self.assert_(check("a/2.txt"))
+        self.assert_(check("a/.hidden.txt"))
 
     def test_readwriteappendseek(self):
         def checkcontents(path, check_contents):
@@ -364,6 +388,7 @@ class TestOSFS(unittest.TestCase):
             finally:
                 if f is not None:
                     f.close()
+            self.assertEqual(read_contents,check_contents)
             return read_contents == check_contents
         test_strings = ["Beautiful is better than ugly.",
                         "Explicit is better than implicit.",
@@ -385,6 +410,7 @@ class TestOSFS(unittest.TestCase):
         f2 = self.fs.open("b.txt", "wb")
         f2.write(test_strings[0])
         f2.close()
+        self.assert_(checkcontents("b.txt", test_strings[0]))
         f3 = self.fs.open("b.txt", "ab")
         f3.write(test_strings[1])
         f3.write(test_strings[2])

fs/zipfs.py

@@ -201,7 +201,7 @@ class ZipFS(FS):
         finally:
             self._lock.release()
 
-    def listdir(self, path="/", wildcard=None, full=False, absolute=False, hidden=False, dirs_only=False, files_only=False):
+    def listdir(self, path="/", wildcard=None, full=False, absolute=False, hidden=True, dirs_only=False, files_only=False):
 
         return self._path_fs.listdir(path, wildcard, full, absolute, hidden, dirs_only, files_only)