Commit ec07d937 by rfkelly0

fix default value for 'hidden' in HideDotFilesFS.listdir (issue #30)

parent 3d3ffb67
...@@ -72,3 +72,28 @@ class TestLimitSizeFS(TestWrapFS): ...@@ -72,3 +72,28 @@ class TestLimitSizeFS(TestWrapFS):
else: else:
self.assertTrue(False,"StorageSpaceError not raised") self.assertTrue(False,"StorageSpaceError not raised")
from fs.wrapfs.hidedotfilesfs import HideDotFilesFS
class TestHideDotFilesFS(unittest.TestCase):
def setUp(self):
self.temp_dir = tempfile.mkdtemp(u"fstest")
open(os.path.join(self.temp_dir, u".dotfile"), 'w').close()
open(os.path.join(self.temp_dir, u"regularfile"), 'w').close()
os.mkdir(os.path.join(self.temp_dir, u".dotdir"))
os.mkdir(os.path.join(self.temp_dir, u"regulardir"))
self.fs = HideDotFilesFS(osfs.OSFS(self.temp_dir))
def tearDown(self):
shutil.rmtree(self.temp_dir)
def test_hidden(self):
self.assertEquals(len(self.fs.listdir(hidden=False)), 2)
def test_nonhidden(self):
self.assertEquals(len(self.fs.listdir(hidden=True)), 4)
def test_default(self):
self.assertEquals(len(self.fs.listdir()), 2)
...@@ -29,7 +29,7 @@ class HideDotFilesFS(WrapFS): ...@@ -29,7 +29,7 @@ class HideDotFilesFS(WrapFS):
return path return path
def listdir(self, path="", **kwds): def listdir(self, path="", **kwds):
hidden = kwds.pop("hidden",True) hidden = kwds.pop("hidden",False)
entries = self.wrapped_fs.listdir(path,**kwds) entries = self.wrapped_fs.listdir(path,**kwds)
if not hidden: if not hidden:
entries = [e for e in entries if not self.is_hidden(e)] entries = [e for e in entries if not self.is_hidden(e)]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment