Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
P
problem-builder
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenEdx
problem-builder
Commits
e1128b13
Commit
e1128b13
authored
Sep 08, 2015
by
Braden MacDonald
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix: assessment review message persisted when trying again
parent
8ee006b5
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
0 deletions
+6
-0
problem_builder/public/js/mentoring_assessment_view.js
+1
-0
problem_builder/tests/integration/test_assessment.py
+5
-0
No files found.
problem_builder/public/js/mentoring_assessment_view.js
View file @
e1128b13
...
@@ -23,6 +23,7 @@ function MentoringAssessmentView(runtime, element, mentoring) {
...
@@ -23,6 +23,7 @@ function MentoringAssessmentView(runtime, element, mentoring) {
$
(
'.grade'
).
html
(
''
);
$
(
'.grade'
).
html
(
''
);
$
(
'.attempts'
).
html
(
''
);
$
(
'.attempts'
).
html
(
''
);
assessmentMessageDOM
.
html
(
''
);
reviewTipsDOM
.
empty
().
hide
();
reviewTipsDOM
.
empty
().
hide
();
}
}
...
...
problem_builder/tests/integration/test_assessment.py
View file @
e1128b13
...
@@ -281,6 +281,10 @@ class MentoringAssessmentTest(MentoringAssessmentBaseTest):
...
@@ -281,6 +281,10 @@ class MentoringAssessmentTest(MentoringAssessmentBaseTest):
self
.
assertEqual
(
message_wrapper
.
text
,
text
)
self
.
assertEqual
(
message_wrapper
.
text
,
text
)
self
.
assertTrue
(
message_wrapper
.
is_displayed
())
self
.
assertTrue
(
message_wrapper
.
is_displayed
())
def
assert_no_message_text
(
self
,
mentoring
):
message_wrapper
=
mentoring
.
find_element_by_css_selector
(
'.assessment-message'
)
self
.
assertEqual
(
message_wrapper
.
text
,
''
)
def
extended_feedback_checks
(
self
,
mentoring
,
controls
,
expected_results
):
def
extended_feedback_checks
(
self
,
mentoring
,
controls
,
expected_results
):
# Multiple choice is third correctly answered question
# Multiple choice is third correctly answered question
self
.
assert_hidden
(
controls
.
review_link
)
self
.
assert_hidden
(
controls
.
review_link
)
...
@@ -346,6 +350,7 @@ class MentoringAssessmentTest(MentoringAssessmentBaseTest):
...
@@ -346,6 +350,7 @@ class MentoringAssessmentTest(MentoringAssessmentBaseTest):
self
.
assert_message_text
(
mentoring
,
"Assessment additional feedback message text"
)
self
.
assert_message_text
(
mentoring
,
"Assessment additional feedback message text"
)
self
.
assert_clickable
(
controls
.
try_again
)
self
.
assert_clickable
(
controls
.
try_again
)
controls
.
try_again
.
click
()
controls
.
try_again
.
click
()
self
.
assert_no_message_text
(
mentoring
)
self
.
freeform_answer
(
self
.
freeform_answer
(
1
,
mentoring
,
controls
,
'This is a different answer'
,
CORRECT
,
saved_value
=
'This is the answer'
1
,
mentoring
,
controls
,
'This is a different answer'
,
CORRECT
,
saved_value
=
'This is the answer'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment