Merge pull request #140 from open-craft/mtyaka/completion-submit-tweaks

Do not show completion checkmark when hide_feedback is enabled

problem_builder/public/js/completion.js

@@ -16,10 +16,12 @@ function CompletionBlock(runtime, element) {
             return $completion.is(':checked');
         },
 
-        handleSubmit: function(result) {
+        handleSubmit: function(result, options) {
             if (typeof result.submission !== 'undefined') {
                 this.updateCompletion(result);
-                $('.submit-result', element).css('visibility', 'visible');
+                if (!options.hide_results) {
+                    $('.submit-result', element).css('visibility', 'visible');
+                }
             }
         },
 

problem_builder/tests/integration/xml_templates/feedback_persistence.xml

@@ -32,6 +32,8 @@
             <pb-tip values='["notwant"]'>Your loss!</pb-tip>
         </pb-rating>
 
+        <pb-completion name="completion_1" question="Did you attend the meeting?" answer="Yes, I did." />
+
         <pb-message type="completed">All Good</pb-message>
         <pb-message type="incomplete">Not done yet</pb-message>
     </problem-builder>