Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
P
problem-builder
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenEdx
problem-builder
Commits
78716cf0
Commit
78716cf0
authored
Oct 28, 2015
by
Tim Krones
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix JS error that causes Step Builder to crash if no review step is present.
parent
9f967274
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
28 additions
and
2 deletions
+28
-2
problem_builder/public/js/mentoring_with_steps.js
+4
-2
problem_builder/public/js/review_step.js
+4
-0
problem_builder/tests/integration/test_step_builder.py
+9
-0
problem_builder/tests/integration/xml_templates/step_builder_no_review_step.xml
+11
-0
No files found.
problem_builder/public/js/mentoring_with_steps.js
View file @
78716cf0
...
@@ -230,8 +230,10 @@ function MentoringWithStepsBlock(runtime, element) {
...
@@ -230,8 +230,10 @@ function MentoringWithStepsBlock(runtime, element) {
}
}
function
hideReviewStep
()
{
function
hideReviewStep
()
{
reviewStep
.
hideAssessmentMessage
();
if
(
reviewStep
)
{
gradeDOM
.
html
(
''
);
reviewStep
.
hideAssessmentMessage
();
reviewStep
.
clearGrade
(
gradeDOM
);
}
}
}
function
getStepToReview
(
event
)
{
function
getStepToReview
(
event
)
{
...
...
problem_builder/public/js/review_step.js
View file @
78716cf0
...
@@ -42,6 +42,10 @@ function ReviewStepBlock(runtime, element) {
...
@@ -42,6 +42,10 @@ function ReviewStepBlock(runtime, element) {
gradeDOM
.
html
(
gradeTemplate
(
data
));
gradeDOM
.
html
(
gradeTemplate
(
data
));
},
'clearGrade'
:
function
(
gradeDOM
)
{
gradeDOM
.
html
(
''
);
}
}
};
};
...
...
problem_builder/tests/integration/test_step_builder.py
View file @
78716cf0
...
@@ -1251,3 +1251,12 @@ class StepBuilderTest(MentoringAssessmentBaseTest, MultipleSliderBlocksTestMixin
...
@@ -1251,3 +1251,12 @@ class StepBuilderTest(MentoringAssessmentBaseTest, MultipleSliderBlocksTestMixin
# Clicking in general should dismiss this message.
# Clicking in general should dismiss this message.
self
.
browser
.
execute_script
(
"$(document).trigger('click')"
)
self
.
browser
.
execute_script
(
"$(document).trigger('click')"
)
self
.
wait_until_hidden
(
message
)
self
.
wait_until_hidden
(
message
)
def
test_no_review_step
(
self
):
step_builder
,
controls
=
self
.
load_assessment_scenario
(
"step_builder_no_review_step.xml"
,
{})
# If client-side code tries to call a method on reviewStep
# even if Step Builder block does not contain a review step,
# the current step will fail to render.
# In that case, submitting an answer and will fail,
# as it requires the corresponding question to be visible:
self
.
freeform_answer
(
None
,
step_builder
,
controls
,
'This is the answer'
,
CORRECT
)
problem_builder/tests/integration/xml_templates/step_builder_no_review_step.xml
0 → 100644
View file @
78716cf0
<step-builder
url_name=
"step-builder"
display_name=
"Step Builder"
>
<sb-step
display_name=
"First Step"
>
<pb-answer
name=
"goal"
question=
"What is your goal?"
/>
</sb-step>
<sb-step
display_name=
"Second Step"
>
<pb-answer
name=
"hobbies"
question=
"What do you like to do for fun?"
/>
</sb-step>
</step-builder>
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment