Merge pull request #71 from open-craft/fix-sub_api-load-issue-oc-1003

Fix: Don't import all the problem builder blocks when the django app is loaded

problem_builder/__init__.py

-from .mentoring import MentoringBlock
-from .answer import AnswerBlock, AnswerRecapBlock
-from .choice import ChoiceBlock
-from .dashboard import DashboardBlock
-from .mcq import MCQBlock, RatingBlock
-from .mrq import MRQBlock
-from .message import MentoringMessageBlock
-from .table import MentoringTableBlock, MentoringTableColumn
-from .tip import TipBlock

problem_builder/tests/integration/base_test.py

@@ -24,7 +24,7 @@ from xblockutils.base_test import SeleniumBaseTest
 # Studio adds a url_name property to each XBlock but Workbench doesn't.
 # Since we rely on it, we need to mock url_name support so it can be set via XML and
 # accessed like a normal field.
-from problem_builder import MentoringBlock
+from problem_builder.mentoring import MentoringBlock
 MentoringBlock.url_name = String()
 
 

problem_builder/tests/integration/test_mcq.py

@@ -23,7 +23,7 @@
 import ddt
 from mock import patch, Mock
 
-from problem_builder import MentoringBlock
+from problem_builder.mentoring import MentoringBlock
 from .base_test import MentoringBaseTest
 
 

problem_builder/tests/integration/test_mentoring.py

@@ -69,6 +69,6 @@ class MentoringThemeTest(MentoringAssessmentBaseTest):
         ('apros', "#ff0000")
     )
     def test_lms_theme_applied(self, theme, expected_color):
-        with mock.patch("problem_builder.MentoringBlock.get_theme") as patched_theme:
+        with mock.patch("problem_builder.mentoring.MentoringBlock.get_theme") as patched_theme:
             patched_theme.return_value = _get_mentoring_theme_settings(theme)
             self.assert_status_icon_color(expected_color)

problem_builder/tests/unit/test_mentoring.py

@@ -2,8 +2,7 @@ import unittest
 import ddt
 from mock import MagicMock, Mock, patch
 from xblock.field_data import DictFieldData
-from problem_builder import MentoringBlock
-from problem_builder.mentoring import _default_theme_config
+from problem_builder.mentoring import MentoringBlock, _default_theme_config
 
 
 class TestMentoringBlock(unittest.TestCase):

problem_builder/tests/unit/test_migration.py

 import copy
-from problem_builder import MentoringBlock
+from problem_builder.mentoring import MentoringBlock
 from mock import MagicMock, Mock
 import unittest
 from xblock.field_data import DictFieldData

problem_builder/v1/tests/test_upgrade.py

@@ -22,7 +22,7 @@ Test that we can upgrade from mentoring v1 to problem builder (v2).
 """
 import ddt
 from lxml import etree
-from problem_builder import MentoringBlock
+from problem_builder.mentoring import MentoringBlock
 from problem_builder.v1.xml_changes import convert_xml_v1_to_v2
 import os.path
 from StringIO import StringIO

setup.py

@@ -40,20 +40,20 @@ def package_data(pkg, root_list):
 # Main ##############################################################
 
 BLOCKS = [
-    'problem-builder = problem_builder:MentoringBlock',
+    'problem-builder = problem_builder.mentoring:MentoringBlock',
 
-    'pb-table = problem_builder:MentoringTableBlock',
-    'pb-column = problem_builder:MentoringTableColumn',
-    'pb-answer = problem_builder:AnswerBlock',
-    'pb-answer-recap = problem_builder:AnswerRecapBlock',
-    'pb-mcq = problem_builder:MCQBlock',
-    'pb-rating = problem_builder:RatingBlock',
-    'pb-mrq = problem_builder:MRQBlock',
-    'pb-message = problem_builder:MentoringMessageBlock',
-    'pb-tip = problem_builder:TipBlock',
-    'pb-choice = problem_builder:ChoiceBlock',
+    'pb-table = problem_builder.table:MentoringTableBlock',
+    'pb-column = problem_builder.table:MentoringTableColumn',
+    'pb-answer = problem_builder.answer:AnswerBlock',
+    'pb-answer-recap = problem_builder.answer:AnswerRecapBlock',
+    'pb-mcq = problem_builder.mcq:MCQBlock',
+    'pb-rating = problem_builder.mcq:RatingBlock',
+    'pb-mrq = problem_builder.mrq:MRQBlock',
+    'pb-message = problem_builder.message:MentoringMessageBlock',
+    'pb-tip = problem_builder.tip:TipBlock',
+    'pb-choice = problem_builder.choice:ChoiceBlock',
 
-    'pb-dashboard = problem_builder:DashboardBlock',
+    'pb-dashboard = problem_builder.dashboard:DashboardBlock',
     # Deprecated. You can temporarily uncomment and run 'python setup.py develop' if you have these blocks
     # installed from testing mentoring v2 and need to get past an error message.
     #'mentoring = problem_builder:MentoringBlock',  # Deprecated alias for problem-builder

test_requirements.txt

--e git+https://github.com/edx/XBlock.git@496d3cb9aca1d9e0a18b0f5e73c7bede824e465f#egg=XBlock
\ No newline at end of file
+-e git+https://github.com/edx/XBlock.git@496d3cb9aca1d9e0a18b0f5e73c7bede824e465f#egg=XBlock
+selenium==2.47.3  # 2.48 is not working atm