Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
P
problem-builder
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenEdx
problem-builder
Commits
0b992c68
Commit
0b992c68
authored
Sep 30, 2015
by
Tim Krones
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Address review comments.
parent
732405c2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
24 additions
and
5 deletions
+24
-5
problem_builder/step.py
+3
-2
problem_builder/tests/integration/test_step_builder.py
+21
-3
No files found.
problem_builder/step.py
View file @
0b992c68
...
...
@@ -262,8 +262,9 @@ class ReviewStepBlock(MessageParentMixin, StudioContainerWithNestedXBlocksMixin,
@XBlock.json_handler
def
get_assessment_message
(
self
,
grade
,
suffix
):
complete
=
grade
[
'complete'
]
max_attempts_reached
=
grade
[
'max_attempts_reached'
]
# Data passed as "grade" comes from "get_grade" handler of Step Builder (MentoringWithExplicitStepsBlock)
complete
=
grade
.
get
(
'complete'
)
max_attempts_reached
=
grade
.
get
(
'max_attempts_reached'
)
return
{
'assessment_message'
:
self
.
assessment_message
(
complete
,
max_attempts_reached
)
}
...
...
problem_builder/tests/integration/test_step_builder.py
View file @
0b992c68
from
.base_test
import
CORRECT
,
INCORRECT
,
PARTIAL
,
MentoringAssessmentBaseTest
,
GetChoices
from
mock
import
patch
from
ddt
import
ddt
,
data
from
workbench.runtime
import
WorkbenchRuntime
from
.base_test
import
CORRECT
,
INCORRECT
,
PARTIAL
,
MentoringAssessmentBaseTest
,
GetChoices
@ddt
class
StepBuilderTest
(
MentoringAssessmentBaseTest
):
...
...
@@ -238,7 +240,23 @@ class StepBuilderTest(MentoringAssessmentBaseTest):
# Last step
# Submit MRQ, go to review
self
.
multiple_response_question
(
None
,
step_builder
,
controls
,
(
"Its beauty"
,),
PARTIAL
,
last
=
True
)
with
patch
.
object
(
WorkbenchRuntime
,
'publish'
)
as
patched_method
:
self
.
multiple_response_question
(
None
,
step_builder
,
controls
,
(
"Its beauty"
,),
PARTIAL
,
last
=
True
)
# Check if "grade" event was published
# Note that we can't use patched_method.assert_called_once_with here
# because there is no way to obtain a reference to the block instance generated from the XML scenario
self
.
assertTrue
(
patched_method
.
called
)
self
.
assertEquals
(
len
(
patched_method
.
call_args_list
),
1
)
block_object
=
self
.
load_root_xblock
()
positional_args
=
patched_method
.
call_args
[
0
]
block
,
event
,
data
=
positional_args
self
.
assertEquals
(
block
.
scope_ids
.
usage_id
,
block_object
.
scope_ids
.
usage_id
)
self
.
assertEquals
(
event
,
'grade'
)
self
.
assertEquals
(
data
,
{
'value'
:
0.625
,
'max_value'
:
1
})
# Review step
expected_results
=
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment