quality improvements

edx_proctoring/api.py

@@ -361,6 +361,7 @@ def get_all_exam_attempts(course_id):
     exam_attempts = ProctoredExamStudentAttempt.get_all_exam_attempts(course_id)
     return [ProctoredExamStudentAttemptSerializer(active_exam).data for active_exam in exam_attempts]
 
+
 def get_filtered_exam_attempts(course_id, search_by):
     """
     returns all exam attempts for a course id filtered by  the search_by string in user names and emails.
@@ -368,6 +369,7 @@ def get_filtered_exam_attempts(course_id, search_by):
     exam_attempts = ProctoredExamStudentAttempt.get_all_exam_attempts(course_id)
     return [ProctoredExamStudentAttemptSerializer(active_exam).data for active_exam in exam_attempts]
 
+
 def get_active_exams_for_user(user_id, course_id=None):
     """
     This method will return a list of active exams for the user,

edx_proctoring/urls.py

@@ -41,7 +41,8 @@ urlpatterns = patterns(  # pylint: disable=invalid-name
         name='edx_proctoring.proctored_exam.attempt'
     ),
     url(
-        r'edx_proctoring/v1/proctored_exam/attempt/course_id/{}/search/(?P<search_by>.+)$'.format(settings.COURSE_ID_PATTERN),
+        r'edx_proctoring/v1/proctored_exam/attempt/course_id/{}/search/(?P<search_by>.+)$'.format(
+            settings.COURSE_ID_PATTERN),
         views.StudentProctoredExamAttemptCollection.as_view(),
         name='edx_proctoring.proctored_exam.attempt.search'
     ),

edx_proctoring/views.py

@@ -42,6 +42,8 @@ from edx_proctoring.serializers import ProctoredExamSerializer
 
 from .utils import AuthenticatedAPIView
 
+ATTEMPTS_PER_PAGE = 1
+
 LOG = logging.getLogger("edx_proctoring_views")
 
 
@@ -400,8 +402,7 @@ class StudentProctoredExamAttemptCollection(AuthenticatedAPIView):
                 exam_attempts = get_all_exam_attempts(course_id)
                 attempt_url = reverse('edx_proctoring.proctored_exam.attempt', args=[course_id])
 
-            # TODO have to change the default attempts per page
-            paginator = Paginator(exam_attempts, 1)  # Show 1 attempts per page
+            paginator = Paginator(exam_attempts, ATTEMPTS_PER_PAGE)
             page = request.GET.get('page')
             try:
                 exam_attempts_page = paginator.page(page)