Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenEdx
edx-platform
Commits
7b621b42
Commit
7b621b42
authored
Sep 28, 2017
by
Adam Palay
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
more thorough nudge
parent
fc3b7d8b
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
89 additions
and
7 deletions
+89
-7
cms/static/js/views/components/add_xblock.js
+28
-4
cms/static/sass/elements/_modules.scss
+26
-1
cms/templates/js/add-xblock-component.underscore
+26
-2
cms/templates/js/add-xblock-unit-button.underscore
+9
-0
No files found.
cms/static/js/views/components/add_xblock.js
View file @
7b621b42
...
@@ -2,15 +2,17 @@
...
@@ -2,15 +2,17 @@
* This is a simple component that renders add buttons for all available XBlock template types.
* This is a simple component that renders add buttons for all available XBlock template types.
*/
*/
define
([
'jquery'
,
'underscore'
,
'gettext'
,
'js/views/baseview'
,
'common/js/components/utils/view_utils'
,
define
([
'jquery'
,
'underscore'
,
'gettext'
,
'js/views/baseview'
,
'common/js/components/utils/view_utils'
,
'js/views/components/add_xblock_button'
,
'js/views/components/add_xblock_menu'
],
'js/views/components/add_xblock_button'
,
'js/views/components/add_xblock_menu'
,
'js/views/utils/xblock_utils'
],
function
(
$
,
_
,
gettext
,
BaseView
,
ViewUtils
,
AddXBlockButton
,
AddXBlockMenu
)
{
function
(
$
,
_
,
gettext
,
BaseView
,
ViewUtils
,
AddXBlockButton
,
AddXBlockMenu
,
XBlockViewUtils
)
{
var
AddXBlockComponent
=
BaseView
.
extend
({
var
AddXBlockComponent
=
BaseView
.
extend
({
events
:
{
events
:
{
'click .new-component .new-component-type .multiple-templates'
:
'showComponentTemplates'
,
'click .new-component .new-component-type .multiple-templates'
:
'showComponentTemplates'
,
'click .new-component .new-component-type .single-template'
:
'createNewComponent'
,
'click .new-component .new-component-type .single-template'
:
'createNewComponent'
,
'click .new-component .cancel-button'
:
'closeNewComponent'
,
'click .new-component .cancel-button'
:
'closeNewComponent'
,
'click .new-component-templates .new-component-template .button-component'
:
'createNewComponent'
,
'click .new-component-templates .new-component-template .button-component'
:
'createNewComponent'
,
'click .new-component-templates .cancel-button'
:
'closeNewComponent'
'click .new-component-templates .cancel-button'
:
'closeNewComponent'
,
'click .new-component .add-unit-button'
:
'addNewUnit'
,
'click .new-component .override-button'
:
'overrideNudge'
},
},
initialize
:
function
(
options
)
{
initialize
:
function
(
options
)
{
...
@@ -19,11 +21,17 @@ define(['jquery', 'underscore', 'gettext', 'js/views/baseview', 'common/js/compo
...
@@ -19,11 +21,17 @@ define(['jquery', 'underscore', 'gettext', 'js/views/baseview', 'common/js/compo
this
.
template
=
this
.
loadTemplate
(
'add-xblock-component'
);
this
.
template
=
this
.
loadTemplate
(
'add-xblock-component'
);
this
.
nudgeTemplate
=
this
.
loadTemplate
(
'add-xblock-component-nudge'
);
this
.
nudgeTemplate
=
this
.
loadTemplate
(
'add-xblock-component-nudge'
);
this
.
model
.
set
({
number_children
:
$
(
'.level-element'
).
length
});
this
.
model
.
set
({
number_children
:
$
(
'.level-element'
).
length
});
this
.
model
.
set
({
overrideNudge
:
false
});
// this.model.on('change:number_children', function(model){
// this.model.on('change:number_children', function(model){
// console.log('number of children changed!');
// console.log('number of children changed!');
// console.log(model.get('number_children'));
// console.log(model.get('number_children'));
// }, this.model);
// }, this.model);
this
.
model
.
on
(
'change:number_children'
,
this
.
render
,
this
);
this
.
model
.
on
(
'change:number_children'
,
this
.
render
,
this
);
this
.
model
.
on
(
'change:overrideNudge'
,
this
.
render
,
this
);
},
overrideNudge
:
function
()
{
this
.
model
.
set
({
overrideNudge
:
true
});
},
},
renderNudge
:
function
()
{
renderNudge
:
function
()
{
...
@@ -32,7 +40,13 @@ define(['jquery', 'underscore', 'gettext', 'js/views/baseview', 'common/js/compo
...
@@ -32,7 +40,13 @@ define(['jquery', 'underscore', 'gettext', 'js/views/baseview', 'common/js/compo
renderNormal
:
function
()
{
renderNormal
:
function
()
{
var
that
=
this
;
var
that
=
this
;
this
.
$el
.
html
(
this
.
template
({
numberChildren
:
that
.
model
.
get
(
'number_children'
)}));
this
.
$el
.
html
(
this
.
template
({
numberChildren
:
that
.
model
.
get
(
'number_children'
),
isVertical
:
that
.
model
.
isVertical
(),
parentId
:
that
.
model
.
get
(
'ancestor_info'
).
ancestors
[
0
].
get
(
'id'
),
defaultNewName
:
that
.
model
.
get
(
'display_name'
),
overrideNudge
:
that
.
model
.
get
(
'overrideNudge'
)
}));
this
.
collection
.
each
(
this
.
collection
.
each
(
function
(
componentModel
)
{
function
(
componentModel
)
{
var
view
,
menu
;
var
view
,
menu
;
...
@@ -91,6 +105,16 @@ define(['jquery', 'underscore', 'gettext', 'js/views/baseview', 'common/js/compo
...
@@ -91,6 +105,16 @@ define(['jquery', 'underscore', 'gettext', 'js/views/baseview', 'common/js/compo
// component appears above them.
// component appears above them.
ViewUtils
.
setScrollOffset
(
self
.
$el
,
oldOffset
);
ViewUtils
.
setScrollOffset
(
self
.
$el
,
oldOffset
);
});
});
},
addNewUnit
:
function
(
event
)
{
var
$target
=
$
(
event
.
currentTarget
);
console
.
log
(
$target
);
// category = $target.data('category');
event
.
preventDefault
();
XBlockViewUtils
.
addXBlock
(
$target
).
done
(
function
(
locator
)
{
ViewUtils
.
redirect
(
'/container/'
+
locator
+
'?action=new'
)
});
}
}
});
});
...
...
cms/static/sass/elements/_modules.scss
View file @
7b621b42
...
@@ -122,17 +122,42 @@
...
@@ -122,17 +122,42 @@
margin-bottom
:
(
$baseline
*
0
.75
);
margin-bottom
:
(
$baseline
*
0
.75
);
color
:
$uxpl-green-base
;
color
:
$uxpl-green-base
;
}
}
button
{
@include
clearfix
();
display
:
inline-block
;
@extend
%t-action3
;
@include
margin-right
(
$baseline
*
0
.75
);
position
:
relative
;
display
:
inline-block
;
width
:
(
$baseline
*
5
);
height
:
(
$baseline
*
5
);
margin-bottom
:
(
$baseline
/
2
);
box-shadow
:
0
1px
1px
$shadow
,
0
1px
0
rgba
(
255
,
255
,
255
,
0
.4
)
inset
;
border-radius
:
(
$baseline
/
4
);
padding
:
0
;
text-align
:
center
;
// @extend %btn-primary-blue;
&
.override-button
{
@extend
%btn-secondary-blue
;
}
&
.add-unit-button-style
{
@extend
%btn-primary-blue
;
margin-left
:
$baseline
;
}
}
// add component - list of green buttons
// add component - list of green buttons
.new-component-type
{
.new-component-type
{
@include
clearfix
();
@include
clearfix
();
// display: inline-block;
li
{
li
{
display
:
inline-block
;
display
:
inline-block
;
}
}
// green button
// green button
.add-xblock-component-button
{
.add-xblock-component-button
{
@extend
%t-action3
;
@extend
%t-action3
;
@include
margin-right
(
$baseline
*
0
.75
);
@include
margin-right
(
$baseline
*
0
.75
);
...
...
cms/templates/js/add-xblock-component.underscore
View file @
7b621b42
<div class="new-component">
<div class="new-component">
<h5><%= gettext("Add New Component") %></h5>
<h5><%= gettext("Add New Component") %></h5>
<p>
There are <%= numberChildren %> components in this unit!
</p>
<p>
Learner engagement is generally higher when units have fewer components. <a href="https://partners.edx.org/" target="_blank">Read more.</a>
</p>
<% if (numberChildren < 4) { %>
<% if (numberChildren < 4
|| overrideNudge
) { %>
<ul class="new-component-type">
<ul class="new-component-type">
</ul>
</ul>
<% } if (numberChildren >= 4) { %>
<p>This unit already contains <%= numberChildren %> components. Sylvia demands that start a new unit.</p>
<% } %>
<% } %>
<% if (isVertical) { %>
<button class="add-unit-button add-unit-button-style" data-category="vertical"
data-parent="<%= parentId %>" data-default-name="<%= defaultNewName %>"
title="<%= interpolate(
gettext('Click to add a new %(xblock_type)s'), { xblock_type: defaultNewName }, true
) %>"
>
<%= interpolate(
gettext('New %(xblock_type)s'),
{ xblock_type: defaultNewName },
true
) %>
</button>
<% } %>
<% if (numberChildren > 3 && !overrideNudge) { %>
<button class="override-button">Thwart Sylvia</button>
<% } %>
</div>
</div>
cms/templates/js/add-xblock-unit-button.underscore
0 → 100644
View file @
7b621b42
<% if (type === 'advanced' || templates.length > 1) { %>
<button type="button" class="multiple-templates add-xblock-component-button" data-type="<%= type %>">
<% } else { %>
<button type="button" class="single-template add-xblock-component-button" data-type="<%= type %>" data-category="<%= templates[0].category %>">
<% } %>
<span class="large-template-icon large-<%= type %>-icon"></span>
<span class="sr"> <%= gettext("Add Component:") %></span>
<span class="name"><%= display_name %></span>
</button>
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment