- 09 Feb, 2016 2 commits
-
-
The aforementioned change to `glob` surfaced a couple errors in the unit tests: 1. `test_glob_literal` was still testing the old behavior of non-existing paths being filtered out. 2. The post-process tests (`test_post_process_dry_run` and `test_post_process`) were now failing because post-process was being run without first collecting the media. This is a case where non-existing files were previously being filtered out silently but now cause an error. Running the collection stage before testing `post_process.
David Trowbridge committed -
Commit bd6b9d89 dramatically changed the way that files are loaded, and had the side-effect of filtering out any files which were sourced by finders outside of the main `STATICFILES_DIRS`. In the case I'm trying to address, we have an extension framework (in Review Board and Djblets) which can load static media from third-party packages which are activated at runtime. This media is loaded by instantiating `StylesheetNode` and `JavascriptNode` from `pipeline.templatetags` in combination with a special finder. Because django-pipeline no longer uses finders before the compile stage, calling `storage.exists` (via `Package.sources` -> `glob`) silently filters these out. Inside `glob`, I agree that it's useful to test existence when trying to expand `*` or `?`, but when the path is just a normal filename, it should be safe to assume that the user knows what they're doing. This causes the paths to be emitted into the rendered template whether or not `staticfiles_storage` claims they exist, and anything which the configured staticfiles finders can't locate will surface as a 404 rather than being silently eaten.
David Trowbridge committed
-
- 08 Jan, 2016 1 commit
-
-
Camilo Nova committed
-
- 06 Jan, 2016 3 commits
-
-
add doc for deactivate collector in develop
leonardo orozco committed -
leonardoo committed
-
adding the ability to disable the collector in develop
leonardo orozco committed
-
- 05 Jan, 2016 1 commit
-
-
leonardoo committed
-
- 03 Jan, 2016 2 commits
-
-
Timothée Peignier committed
-
Timothée Peignier committed
-
- 02 Jan, 2016 10 commits
-
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
This reverts commit 7520777f.
Timothée Peignier committed -
This reverts commit f05fe5e5.
Timothée Peignier committed -
Timothée Peignier committed
-
- 30 Dec, 2015 5 commits
-
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Names on disk and config files should not have to be safe for shells to interpret. As close to possible, we should take literals and give literals to the OS kernel to operate on directly. For filename globs, it is our responsiblility to expand them, and if we had no problem with backwards compatibility, we would insist config files' SCRIPT_ARGUMENTS parameters are tuples of discrete values. Delegating those to a shell breaks clear boundaries of interpreetation and will always be prone to errors, oversight, and incompatibility. So, now, we never take names that are unsafe and try to make then safe for a shell, because we don't need a shell. This fixes #444, which had problems with Windows paths being insensible to the crazy quoting we hoped would make a filename safe for a shell. This fixes #494, which had a compiler-attempt stdout captured as part of a string interpreted by a shell. When the compiler didn't exist, that shell expression STILL created empty files, and the pipeline thenafter served an empty file as if it were real compiler output.
Chad Miller committed
-
- 29 Dec, 2015 4 commits
-
-
Fix literal markup for settings
Timothée Peignier committed -
Remove unnecessary indentation
Timothée Peignier committed -
To avoid wrapping text in `<blockquote>` tags.
Sławek Ehlert committed -
In headings and one non-heading. This is probably a leftover after some semi-automated way of removing that `PIPELINE_` prefix.
Sławek Ehlert committed
-
- 21 Dec, 2015 1 commit
-
-
Jannis Leidel committed
-
- 20 Dec, 2015 4 commits
-
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
- 18 Dec, 2015 6 commits
-
-
Added password for jazzband PyPI user account.
Timothée Peignier committed -
Fixes https://github.com/jazzband/roadies/issues/3.
Jannis Leidel committed -
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
Timothée Peignier committed
-
- 03 Dec, 2015 1 commit
-
-
Timothée Peignier committed
-