prototype based on static files app new features

pipeline/conf/settings.py

@@ -2,23 +2,12 @@ from django.conf import settings
 from django.core.exceptions import ImproperlyConfigured
 
 
-PIPELINE_ROOT = getattr(settings, 'PIPELINE_ROOT', settings.MEDIA_ROOT)
-PIPELINE_URL = getattr(settings, 'PIPELINE_URL', settings.MEDIA_URL)
-
 PIPELINE = getattr(settings, 'PIPELINE', not settings.DEBUG)
 PIPELINE_ROOT = getattr(settings, 'PIPELINE_ROOT', settings.STATIC_ROOT)
 PIPELINE_URL = getattr(settings, 'PIPELINE_URL', settings.STATIC_URL)
-PIPELINE_AUTO = getattr(settings, 'PIPELINE_AUTO', True)
-PIPELINE_VERSION = getattr(settings, 'PIPELINE_VERSION', False)
-PIPELINE_VERSION_PLACEHOLDER = getattr(settings, 'PIPELINE_VERSION_PLACEHOLDER', '?')
-PIPELINE_VERSION_DEFAULT = getattr(settings, 'PIPELINE_VERSION_DEFAULT', '0')
-PIPELINE_VERSION_REMOVE_OLD = getattr(settings, 'PIPELINE_VERSION_REMOVE_OLD', True)
-PIPELINE_VERSIONING = getattr(settings, 'PIPELINE_VERSIONING', 'pipeline.versioning.mtime.MTimeVersioning')
-
-PIPELINE_CACHE_TIMEOUT = getattr(settings, 'PIPELINE_CACHE_TIMEOUT', 63072000)
 
 PIPELINE_STORAGE = getattr(settings, 'PIPELINE_STORAGE',
-    'pipeline.storage.PipelineStorage')
+    'pipeline.storage.PipelineFinderStorage')
 
 PIPELINE_CSS_COMPRESSOR = getattr(settings, 'PIPELINE_CSS_COMPRESSOR',
     'pipeline.compressors.yui.YUICompressor'

pipeline/packager.py

-import os
 import urlparse
 
 from django.core.files.base import ContentFile
@@ -9,14 +8,12 @@ from pipeline.compressors import Compressor
 from pipeline.glob import glob
 from pipeline.signals import css_compressed, js_compressed
 from pipeline.storage import storage
-from pipeline.versioning import Versioning
 
 
 class Packager(object):
     def __init__(self, verbose=False, css_packages=None, js_packages=None):
         self.verbose = verbose
         self.compressor = Compressor(verbose)
-        self.versioning = Versioning(verbose)
         self.compiler = Compiler(verbose)
         if css_packages is None:
             css_packages = settings.PIPELINE_CSS
@@ -53,28 +50,16 @@ class Packager(object):
     def compile(self, paths):
         return self.compiler.compile(paths)
 
-    def pack(self, package, compress, signal, sync=False, force=False, **kwargs):
-        if settings.PIPELINE_AUTO or (force and sync):
-            need_update, version = self.versioning.need_update(
-                package['output'], package['paths'])
-            if need_update or force:
-                output_filename = self.versioning.output_filename(
-                    package['output'],
-                    version
-                )
-                self.versioning.cleanup(package['output'])
-                if self.verbose:
-                    print "Version: %s" % version
-                    print "Saving: %s" % output_filename
-                paths = self.compile(package['paths'])
-                content = compress(paths,
-                    asset_url=self.individual_url(output_filename), **kwargs)
-                self.save_file(output_filename, content)
-        else:
-            filename_base, filename = os.path.split(package['output'])
-            version = self.versioning.version_from_file(filename_base, filename, force=force)
-        signal.send(sender=self, package=package, version=version, **kwargs)
-        return self.versioning.output_filename(package['output'], version)
+    def pack(self, package, compress, signal, **kwargs):
+        output_filename = package["output"]
+        if self.verbose:
+            print "Saving: %s" % output_filename
+        paths = self.compile(package['paths'])
+        content = compress(paths,
+            asset_url=self.individual_url(output_filename), **kwargs)
+        self.save_file(output_filename, content)
+        signal.send(sender=self, package=package, **kwargs)
+        return output_filename
 
     def pack_javascripts(self, package, **kwargs):
         if 'externals' in package:

pipeline/signals.py

-import os
-
-from django.core.cache import cache
-from django.dispatch import Signal, receiver
-
-from pipeline.conf import settings
+from django.dispatch import Signal
 
 
 css_compressed = Signal(providing_args=["package", "version"])
 js_compressed = Signal(providing_args=["package", "version"])
-
-
-@receiver(css_compressed)
-@receiver(js_compressed)
-def invalidate_cache(sender, package, version, **kwargs):
-    filename_base, filename = os.path.split(package['output'])
-    cache.set("pipeline:%s" % filename, str(version),
-            settings.PIPELINE_CACHE_TIMEOUT)

pipeline/storage.py

-import errno
-import os
-
-from datetime import datetime
-
 from django.contrib.staticfiles import finders
+from django.contrib.staticfiles.storage import CachedStaticFilesStorage, StaticFilesStorage
 from django.core.exceptions import ImproperlyConfigured
-from django.core.files.storage import FileSystemStorage, get_storage_class
+from django.core.files.storage import get_storage_class
 from django.utils.functional import LazyObject
 
-from django.contrib.staticfiles.storage import CachedFilesMixin  # FIXME : This break if django < 1.4
 
 from pipeline.conf import settings
 
 
-class PipelineStorage(FileSystemStorage):
-    def __init__(self, location=None, base_url=None, *args, **kwargs):
-        if location is None:
-            location = settings.PIPELINE_ROOT
-        if base_url is None:
-            base_url = settings.PIPELINE_URL
-        super(PipelineStorage, self).__init__(location, base_url, *args, **kwargs)
-
-    def accessed_time(self, name):
-        return datetime.fromtimestamp(os.path.getatime(self.path(name)))
-
-    def created_time(self, name):
-        return datetime.fromtimestamp(os.path.getctime(self.path(name)))
-
-    def modified_time(self, name):
-        return datetime.fromtimestamp(os.path.getmtime(self.path(name)))
-
-    def get_available_name(self, name):
-        if self.exists(name):
-            self.delete(name)
-        return name
-
-    def _open(self, name, mode='rb'):
-        full_path = self.path(name)
-        directory = os.path.dirname(full_path)
-        if not os.path.exists(directory):
-            try:
-                os.makedirs(directory)
-            except OSError, e:
-                if e.errno != errno.EEXIST:
-                    raise
-        if not os.path.isdir(directory):
-            raise IOError("%s exists and is not a directory." % directory)
-        return super(PipelineStorage, self)._open(name, mode)
-
-
-class BaseFinderStorage(PipelineStorage):
+class BaseFinderStorage(StaticFilesStorage):
     finders = None
 
     def __init__(self, finders=None, *args, **kwargs):
@@ -76,15 +35,27 @@ class PipelineFinderStorage(BaseFinderStorage):
     finders = finders
 
 
-class CachedFinderStorage(BaseFinderStorage, CachedFilesMixin):
-    finders = finders
-
+class PipelineStorage(CachedStaticFilesStorage):
     def post_process(self, paths, dry_run=False, **options):
-        processed_files = []
+        from pipeline.packager import Packager
         if dry_run:
-            return processed_files
-        # FIXME: Do some pipeline stuff
-        return super(CachedFinderStorage, self).post_process(processed_files, dry_run, **options)
+            return []
+        packager = Packager()
+        for package_name in packager.packages['css']:
+            package = packager.package_for('css', package_name)
+            output_file = packager.pack_stylesheets(package)
+            for path in package["paths"]:
+                paths.remove(path)
+            paths.append(output_file)
+        for package_name in packager.packages['js']:
+            package = packager.package_for('js', package_name)
+            output_file = packager.pack_javascripts(package)
+            for path in package["paths"]:
+                paths.remove(path)
+            for path in package["templates"]:
+                paths.remove(path)
+            paths.append(output_file)
+        return super(PipelineStorage, self).post_process(paths, dry_run, **options)
 
 
 class DefaultStorage(LazyObject):

pipeline/templatetags/compressed.py

 from django import template
+from django.contrib.staticfiles.storage import staticfiles_storage
 from django.template.loader import render_to_string
 
 from pipeline.conf import settings
@@ -24,20 +25,19 @@ class CompressedCSSNode(template.Node):
             return ''  # fail silently, do not return anything if an invalid group is specified
 
         if settings.PIPELINE:
-            compressed_path = self.packager.pack_stylesheets(package)
-            return self.render_css(package, compressed_path)
+            return self.render_css(package)
         else:
             package['paths'] = self.packager.compile(package['paths'])
             return self.render_individual(package)
 
-    def render_css(self, package, path):
+    def render_css(self, package):
         context = {}
         if not 'template' in package:
             package['template'] = "pipeline/css.html"
         if 'context' in package:
             context = package['context']
         context.update({
-            'url': self.packager.individual_url(path)
+            'url': staticfiles_storage.url(package["output"])
         })
         return render_to_string(package['template'], context)
 
@@ -66,21 +66,20 @@ class CompressedJSNode(template.Node):
             return '\n'.join([self.render_external(package, url) for url in package['externals']])
 
         if settings.PIPELINE:
-            compressed_path = self.packager.pack_javascripts(package)
-            return self.render_js(package, compressed_path)
+            return self.render_js(package)
         else:
             package['paths'] = self.packager.compile(package['paths'])
             templates = self.packager.pack_templates(package)
             return self.render_individual(package, templates)
 
-    def render_js(self, package, path):
+    def render_js(self, package):
         context = {}
         if not 'template' in package:
             package['template'] = "pipeline/js.html"
         if 'context' in package:
             context = package['context']
         context.update({
-            'url': self.packager.individual_url(path)
+            'url': staticfiles_storage.url(package["output"])
         })
         return render_to_string(package['template'], context)