livescript.py
666 Bytes
-
Make compilers run directly, not inside shells · 1f6b48ae
Names on disk and config files should not have to be safe for shells to interpret. As close to possible, we should take literals and give literals to the OS kernel to operate on directly. For filename globs, it is our responsiblility to expand them, and if we had no problem with backwards compatibility, we would insist config files' SCRIPT_ARGUMENTS parameters are tuples of discrete values. Delegating those to a shell breaks clear boundaries of interpreetation and will always be prone to errors, oversight, and incompatibility. So, now, we never take names that are unsafe and try to make then safe for a shell, because we don't need a shell. This fixes #444, which had problems with Windows paths being insensible to the crazy quoting we hoped would make a filename safe for a shell. This fixes #494, which had a compiler-attempt stdout captured as part of a string interpreted by a shell. When the compiler didn't exist, that shell expression STILL created empty files, and the pipeline thenafter served an empty file as if it were real compiler output.
Chad Miller committed