Merge pull request #1642 from edx/revert-1641-derf/validate_certs_no

Revert "validate certs=no on apt_repository due to ansible bug"

playbooks/roles/common/tasks/main.yml

@@ -33,7 +33,7 @@
 # GitHub requires version 1.7.10 or later
 # https://help.github.com/articles/https-cloning-errors
 - name: Add git apt repository
-  apt_repository: repo="{{ common_git_ppa }}" validate_certs=no
+  apt_repository: repo="{{ common_git_ppa }}"
 
 - name: Install role-independent useful system packages
   # do this before log dir setup; rsyslog package guarantees syslog user present

playbooks/roles/datadog/tasks/main.yml

@@ -27,7 +27,7 @@
     - datadog
 
 - name: install apt repository
-  apt_repository: repo='deb http://apt.datadoghq.com/ unstable main' update_cache=yes validate_certs=no
+  apt_repository: repo='deb http://apt.datadoghq.com/ unstable main' update_cache=yes
   tags:
     - datadog
 

playbooks/roles/edxapp/tasks/main.yml

@@ -62,7 +62,7 @@
 
 # adding chris-lea nodejs repo
 - name: add ppas for current versions of nodejs
-  apt_repository: repo="{{ edxapp_chrislea_ppa }}" validate_certs=no
+  apt_repository: repo="{{ edxapp_chrislea_ppa }}"
 
 - name: install system packages on which LMS and CMS rely
   apt: pkg={{','.join(edxapp_debian_pkgs)}} state=present update_cache=yes

playbooks/roles/jenkins_admin/tasks/main.yml

@@ -34,7 +34,7 @@
   when: JENKINS_ADMIN_S3_PROFILE.secret_key is not defined
 
 - name: add admin specific apt repositories
-  apt_repository: repo="{{ item }}" state=present update_cache=yes validate_certs=no
+  apt_repository: repo="{{ item }}" state=present update_cache=yes
   with_items: jenkins_admin_debian_repos
 
 - name: create the scripts directory

playbooks/roles/jenkins_worker/tasks/system.yml

@@ -28,7 +28,7 @@
 
 # adding chris-lea nodejs repo
 - name: add ppas for current versions of nodejs
-  apt_repository: repo="{{ jenkins_chrislea_ppa }}" validate_certs=no
+  apt_repository: repo="{{ jenkins_chrislea_ppa }}"
 
 - name: Install system packages
   apt: pkg={{','.join(jenkins_debian_pkgs)}}

playbooks/roles/mongo/tasks/main.yml

@@ -24,7 +24,6 @@
   apt_repository: >
     repo='{{ MONGODB_REPO }}'
     state=present
-    validate_certs=no
 
 - name: install mongo server and recommends
   apt: >

playbooks/roles/newrelic/tasks/main.yml

@@ -38,7 +38,7 @@
   when: ansible_distribution == 'Amazon'
 
 - name: install apt repository
-  apt_repository: repo="{{ NEWRELIC_DEBIAN_REPO }}" update_cache=yes validate_certs=no
+  apt_repository: repo="{{ NEWRELIC_DEBIAN_REPO }}" update_cache=yes
   when: ansible_distribution == 'Ubuntu'
 
 - name: install newrelic agent (apt)

playbooks/roles/rabbitmq/tasks/main.yml

@@ -10,7 +10,7 @@
   apt: pkg={{",".join(rabbitmq_debian_pkgs)}} state=present
 
 - name: add rabbit repository
-  apt_repository: repo="{{rabbitmq_repository}}" state=present update_cache=yes validate_certs=no
+  apt_repository: repo="{{rabbitmq_repository}}" state=present update_cache=yes
 
 - name: fetch the rabbitmq server deb
   get_url: >

playbooks/roles/redis/tasks/main.yml

@@ -22,7 +22,7 @@
 #
 
 - name: add the redis ppa
-  apt_repository: repo="{{ redis_ppa }}" validate_certs=no
+  apt_repository: repo="{{ redis_ppa }}"
 
 - name: install redis system packages
   apt: pkg={{ item }} install_recommends=yes state=present