Commit bf4e0d12 by Feanil Patel

Update from PR Review.

Move overridable defaults to the top of the defaults file.
Remove the handlers stub.
parent 960a1080
...@@ -9,11 +9,26 @@ ...@@ -9,11 +9,26 @@
# #
## ##
# Defaults for role jenkins_admin # Defaults for role jenkins_admin
# #
# #
# vars are namespace with the module name. # vars are namespace with the module name.
# #
JENKINS_ADMIN_NAME: 'default_jenkins_name'
# jenkins_admin also requires other variables that are not defined by default.
# JENKINS_ADMIN_S3_PROFILE: !!null
# JENKINS_ADMIN_CONFIGURATION_REPO: !!null
# JENKINS_ADMIN_CONFIGURATION_SECURE_REPO: !!null
#
# # Local path to the key to use to checkout secure repos on jenkins and in abbey
# JENKINS_ADMIN_GIT_KEY_LOCAL_PATH: !!null
#
# # EC2 Key to use when bringing up the abbey instance in ec2 (aws key-pair)
# JENKINS_ADMIN_EC2_KEY: !!null
jenkins_admin_role_name: jenkins_admin jenkins_admin_role_name: jenkins_admin
# #
...@@ -35,17 +50,3 @@ jenkins_admin_jobs: ...@@ -35,17 +50,3 @@ jenkins_admin_jobs:
- 'prepare-edxapp' - 'prepare-edxapp'
- 'prepare-forum' - 'prepare-forum'
- 'build-ami' - 'build-ami'
JENKINS_ADMIN_NAME: 'default_jenkins_name'
# jenkins_admin also requires other variables that are not defined by default.
# JENKINS_ADMIN_S3_PROFILE: !!null
# JENKINS_ADMIN_CONFIGURATION_REPO: !!null
# JENKINS_ADMIN_CONFIGURATION_SECURE_REPO: !!null
#
# # Local path to the key to use to checkout secure repos on jenkins and in abbey
# JENKINS_ADMIN_GIT_KEY_LOCAL_PATH: !!null
#
# # EC2 Key to use when bringing up the abbey instance in ec2 (aws key-pair)
# JENKINS_ADMIN_EC2_KEY: !!null
---
#
# edX Configuration
#
# github: https://github.com/edx/configuration
# wiki: https://github.com/edx/configuration/wiki
# code style: https://github.com/edx/configuration/wiki/Ansible-Coding-Conventions
# license: https://github.com/edx/configuration/blob/master/LICENSE.TXT
#
#
#
# Handlers for role jenkins_admin
#
# Overview:
#
#
- name: notify me
debug: msg="stub handler"
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment