Remove objectionable braces from when: conditions

playbooks/edx-east/create_rds_secondary.yml

@@ -16,7 +16,7 @@
     - name: Validate arguments
       fail:
         msg: "One or more arguments were not set correctly: {{ item }}"
-      when: not {{ item }}
+      when: not item
       with_items:
         - from_db
         - rds_name

playbooks/edx-east/promote_rds_secondary.yml

@@ -21,7 +21,7 @@
     - name: Validate arguments
       fail:
         msg: "One or more arguments were not set correctly: {{ item }}"
-      when: not {{ item }}
+      when: not item
       with_items:
         - rds_name
         - admin_password
@@ -52,7 +52,7 @@
     - name: Modify edxapp history RDS
       shell: >
         aws rds modify-db-instance
-        --db-instance-identifier {{ rds_name }}        
+        --db-instance-identifier {{ rds_name }}
         --apply-immediately
         --multi-az
         --master-user-password {{ admin_password }}

playbooks/roles/common/tasks/main.yml

@@ -2,7 +2,7 @@
 - name: Check Configuration Sources
   fail:
     msg: "Configuration Sources Checking (COMMON_EXTRA_CONFIGURATION_SOURCES_CHECKING) is enabled, you must define {{ item }}"
-  when: COMMON_EXTRA_CONFIGURATION_SOURCES_CHECKING and ({{ item }} is not defined or {{ item }} != True)
+  when: COMMON_EXTRA_CONFIGURATION_SOURCES_CHECKING and (item is not defined or item != True)
   with_items: "{{ COMMON_EXTRA_CONFIGURATION_SOURCES }}"
   tags:
     - "install"

playbooks/roles/ecommerce/meta/main.yml

@@ -9,7 +9,7 @@
 #
 ##
 # Role includes for role ecommerce
-# 
+#
 dependencies:
   - common
   - supervisor
@@ -25,6 +25,6 @@ dependencies:
   - role: edx_themes
     theme_users:
       - "{{ ecommerce_user }}"
-    when: "{{ ECOMMERCE_ENABLE_COMPREHENSIVE_THEMING }}"
+    when: ECOMMERCE_ENABLE_COMPREHENSIVE_THEMING
 
   - oraclejdk

playbooks/roles/edxapp/meta/main.yml

@@ -7,4 +7,4 @@ dependencies:
   - role: edx_themes
     theme_users:
       - "{{ edxapp_user }}"
-    when: "{{ EDXAPP_ENABLE_COMPREHENSIVE_THEMING }}"
+    when: EDXAPP_ENABLE_COMPREHENSIVE_THEMING

playbooks/roles/mount_ebs/tasks/main.yml

@@ -23,7 +23,7 @@
     src: "{{ (ansible_mounts | selectattr('device', 'equalto', item.device) | first | default({'device': None})).device }}"
     fstype: "{{ (ansible_mounts | selectattr('device', 'equalto', item.device) | first | default({'fstype': None})).fstype }}"
     state: unmounted
-  when: "{{ UNMOUNT_DISKS and (ansible_mounts | selectattr('device', 'equalto', item.device) | first | default({'fstype': None})).fstype != item.fstype }}"
+  when: UNMOUNT_DISKS and (ansible_mounts | selectattr('device', 'equalto', item.device) | first | default({'fstype': None})).fstype != item.fstype
   with_items: "{{ volumes }}"
 
 # Noop & reports "ok" if fstype is correct

playbooks/roles/splunk-server/tasks/main.yml

@@ -10,13 +10,13 @@
 #
 #
 # Tasks for role splunk-server
-# 
+#
 # Overview:
-# 
+#
 #
 # Dependencies:
 #
-# 
+#
 # Example play:
 #
 #
@@ -44,7 +44,7 @@
     owner: splunk
     group: splunk
     mode: "0400"
-  when: "{{ SPLUNK_SSL_CERT is defined and SPLUNK_SSL_CERT | length > 0 }}"
+  when: SPLUNK_SSL_CERT is defined and SPLUNK_SSL_CERT | length > 0
   with_together:
     - [forwarder.pem, cacert.pem]
     - ["{{ SPLUNK_SSL_CERT }}", "{{ SPLUNK_SSL_ROOT_CA }}"]
@@ -150,9 +150,9 @@
     - install:configuration
 
 - name: restart splunk
-  service: 
+  service:
     name: splunk
-    state: restarted 
+    state: restarted
   tags:
     - "install"
     - "install:configuration"

playbooks/roles/splunkforwarder/tasks/main.yml

@@ -115,7 +115,7 @@
     owner: splunk
     group: splunk
     mode: "0400"
-  when: "{{ item.ssl_cert is defined }}"
+  when: item.ssl_cert is defined
   with_items: "{{ SPLUNKFORWARDER_SERVERS }}"
 
 - name: Write root CA to disk
@@ -125,7 +125,7 @@
     owner: splunk
     group: splunk
     mode: "0400"
-  when: "{{ item.ssl_cert is defined }}"
+  when: item.ssl_cert is defined
   with_items: "{{ SPLUNKFORWARDER_SERVERS }}"
 
 - name: Create inputs and outputs configuration