Merge pull request #3903 from edx/edx/kdmccormick/remove-insights-support-url

Remove outdated `SUPPORT_URL` setting in `INSIGHTS_CONFIG`

CHANGELOG.md

@@ -271,3 +271,6 @@
 
 - Role: insights
   - Removed `INSIGHTS_FEEDBACK_EMAIL` which is no longer used, as it was deemed redundant with `INSIGHTS_SUPPORT_EMAIL`.
+
+- Role: insights
+  - Removed `SUPPORT_EMAIL` setting from `INSIGHTS_CONFIG`, as it is was replaced by `SUPPORT_URL`.

playbooks/roles/insights/defaults/main.yml

@@ -19,8 +19,6 @@ INSIGHTS_MKTG_BASE: 'http://example.com'
 INSIGHTS_LOGOUT_URL: '{{ INSIGHTS_MKTG_BASE }}/accounts/logout/'
 INSIGHTS_PRIVACY_POLICY_URL: '{{ INSIGHTS_MKTG_BASE }}/privacy-policy'
 INSIGHTS_TERMS_OF_SERVICE_URL: '{{ INSIGHTS_MKTG_BASE }}/terms-service'
-# Delete the 'INSIGHTS_SUPPORT_URL' once the release will out for 'INSIGHTS_SUPPORT_EMAIL'
-INSIGHTS_SUPPORT_URL: ''
 INSIGHTS_SUPPORT_EMAIL: ''
 INSIGHTS_CMS_COURSE_SHORTCUT_BASE_URL: '{{ INSIGHTS_LMS_BASE }}/course'
 INSIGHTS_OAUTH2_SECRET: 'secret'
@@ -85,8 +83,6 @@ INSIGHTS_SESSION_EXPIRE_AT_BROWSER_CLOSE: false
 # This block of config is dropped into /edx/etc/insights.yml
 # and is read in by analytics_dashboard/settings/production.py
 INSIGHTS_CONFIG:
-  # Delete the 'SUPPORT_URL' once the release will out for 'SUPPORT_EMAIL'
-  SUPPORT_URL: '{{ INSIGHTS_SUPPORT_URL }}'
   SUPPORT_EMAIL: '{{ INSIGHTS_SUPPORT_EMAIL }}'
   DOCUMENTATION_LOAD_ERROR_URL: '{{ INSIGHTS_DOC_BASE }}/Reference.html#error-conditions'
   SEGMENT_IO_KEY: '{{ INSIGHTS_SEGMENT_IO_KEY }}'