More things found in testing.

playbooks/roles/analytics_api/tasks/main.yml

@@ -64,8 +64,8 @@
     - install:app-requirements
 
 - name: migrate
-  shell:
-  args: "DB_MIGRATION_USER='{{ COMMON_MYSQL_MIGRATE_USER }}' DB_MIGRATION_PASS='{{ COMMON_MYSQL_MIGRATE_PASS }}' {{ analytics_api_home }}/venvs/{{ analytics_api_service_name }}/bin/python ./manage.py migrate --noinput"
+  shell: "DB_MIGRATION_USER='{{ COMMON_MYSQL_MIGRATE_USER }}' DB_MIGRATION_PASS='{{ COMMON_MYSQL_MIGRATE_PASS }}' {{ analytics_api_home }}/venvs/{{ analytics_api_service_name }}/bin/python ./manage.py migrate --noinput"
+  args:
     chdir: "{{ analytics_api_code_dir }}"
   become_user: "{{ analytics_api_user }}"
   environment: "{{ analytics_api_environment }}"

playbooks/roles/antivirus/tasks/main.yml

@@ -46,7 +46,7 @@
   template:
     src: s3_bucket_virus_scan.sh.j2
     dest: "{{ antivirus_app_dir }}/s3_bucket_virus_scan.sh"
-    mode=0555
+    mode: "0555"
     owner: "{{ antivirus_user }}"
     group: "{{ antivirus_user }}"
 

playbooks/roles/discovery/tasks/main.yml

@@ -78,8 +78,8 @@
 
 - name: create nodeenv
   shell: "{{ discovery_venv_dir }}/bin/nodeenv {{ discovery_nodeenv_dir }} --node={{ discovery_node_version }} --prebuilt"
-    args:
-      creates: "{{ discovery_nodeenv_dir }}"
+  args:
+    creates: "{{ discovery_nodeenv_dir }}"
   become_user: "{{ discovery_user }}"
   tags:
     - install
@@ -95,8 +95,8 @@
 
 - name: install bower dependencies
   shell: ". {{ discovery_nodeenv_bin }}/activate && {{ discovery_node_bin }}/bower install --production --config.interactive=false"
-    args:
-      chdir: "{{ discovery_code_dir }}"
+  args:
+    chdir: "{{ discovery_code_dir }}"
   become_user: "{{ discovery_user }}"
   tags:
     - install

playbooks/roles/elasticsearch-monitor/tasks/main.yml

@@ -42,7 +42,7 @@
 
 - name: register/start elasticsearch plugin
   shell: "./npi add-service {{ ELASTICSEARCH_MONITOR_PLUGIN }} --start --user={{ NEWRELIC_USER }}"
-    args:
-      chdir: "{{ NEWRELIC_NPI_PREFIX }}"
+  args:
+    chdir: "{{ NEWRELIC_NPI_PREFIX }}"
   become_user: "root"
 

playbooks/roles/gh_mirror/tasks/main.yml

@@ -34,7 +34,7 @@
 
 - name: install debian packages
   apt:
-    pkg: "{{ ",".join(gh_mirror_debian_pkgs) }}"
+    pkg: '{{ ",".join(gh_mirror_debian_pkgs) }}'
     state: present
     update_cache: yes
 

playbooks/roles/gitreload/tasks/main.yml

@@ -76,7 +76,7 @@
   file:
     src: "{{ gitreload_venv_bin }}/{{ item }}"
     dest: "{{ COMMON_BIN_DIR }}/{{ item }}.gitreload"
-    state=link
+    state: "link"
   with_items:
   - python
   - pip

playbooks/roles/hadoop_common/tasks/main.yml

@@ -65,7 +65,8 @@
   lineinfile:
     dest: /etc/sudoers
     state: present
-    regexp: "'^%hadoop ALL\=' line='%hadoop ALL=(ALL) NOPASSWD:ALL'"
+    regexp: '^%hadoop ALL\='
+    line: '%hadoop ALL=(ALL) NOPASSWD:ALL'
     validate: 'visudo -cf %s'
 
 - name: check if downloaded and extracted
@@ -213,7 +214,7 @@
 - name: service directory exists
   file:
     path: "{{ HADOOP_COMMON_SERVICES_DIR }}"
-    mode=0750
+    mode: "0750"
     owner: "{{ hadoop_common_user }}"
     group: "{{ hadoop_common_group }}"
     state: directory

playbooks/roles/insights/tasks/main.yml

@@ -63,7 +63,7 @@
 
 - name: install bower dependencies
   shell: ". {{ insights_venv_dir }}/bin/activate && . {{ insights_nodeenv_bin }}/activate && {{ insights_node_bin }}/bower install --production --config.interactive=false"
-   args:
+  args:
     chdir: "{{ insights_code_dir }}"
 
   become_user: "{{ insights_user }}"
@@ -107,7 +107,7 @@
 - name: compile translations
   shell: ". {{ insights_venv_dir }}/bin/activate && i18n_tool generate -v"
   args:
-    chdir: {{ insights_code_dir }}/analytics_dashboard
+    chdir: "{{ insights_code_dir }}/analytics_dashboard"
   become_user: "{{ insights_user }}"
   tags:
     - assets

playbooks/roles/mariadb/tasks/main.yml

@@ -46,7 +46,7 @@
 - name: remove bind-address
   lineinfile:
     dest: /etc/mysql/my.cnf
-    regexp: "^bind-address\s+=\s+127\.0\.0\.1$"
+    regexp: '^bind-address\s+=\s+127\.0\.0\.1$'
     state: absent
   when: MARIADB_LISTEN_ALL|bool or MARIADB_CLUSTERED|bool
 
@@ -66,7 +66,7 @@
 
 - name: create all analytics dbs
   mysql_db:
-    db: {{ item }}
+    db: "{{ item }}"
     state: present
     encoding: utf8
   with_items: MARIADB_ANALYTICS_DATABASES