code review items

playbooks/roles/analytics-server/tasks/main.yml

@@ -19,6 +19,8 @@
 #
 # Dependencies:
 #
+# common role
+#
 # Depends upon the automated role
 # 
 # Example play:
@@ -70,7 +72,7 @@
 
 
 - name: analytics-server | ensure .bashrc exists
-  shell: touch {{ as_home }}/.bashrc
+  file: path={{ as_home }}/.bashrc state=touch
   sudo: true  
   sudo_user: "{{ as_user }}"
   tags:
@@ -109,7 +111,8 @@
 - name: analytics-server | create config
   template: 
     src=opt/wwc/analytics.auth.json.j2
-    dest=/opt/wwc/analytics.auth.json 
+    dest=/opt/wwc/analytics.auth.json
+    mode=0600
     owner="{{ as_web_user }}" group="{{ as_web_user }}"
   tags:
   - analytics-server

playbooks/roles/s3fs/tasks/main.yml

@@ -36,7 +36,7 @@
 # - name: my_role | mount s3 buckets
 #   mount:
 #     name={{ item.mount_point }} src={{ item.bucket }} fstype=fuse.s3fs
-#     opts=use_cache=/tmp,iam_role={{ task_iam_role }} state=mounted
+#     opts=use_cache=/tmp,iam_role={{ task_iam_role }},allow_other state=mounted
 #   with_items: "{{ myrole_s3fs_mounts }}"
 # 
 # Example play: