OPS-241 Ansible: MySql 5.6 installs should remove the 'test' database

playbooks/edx-east/mysql.yml

+- name: Deploy MySQL
+  hosts: all
+  sudo: True
+  gather_facts: True
+  roles:
+    - mysql

playbooks/roles/mysql/defaults/main.yml

@@ -3,4 +3,6 @@ mysql_debian_pkgs:
   # Note that mysql 5.6 is installed from a non standard PPA in tasks/main.yml
   # It is not listed here because of non-standard steps required to install
   # mysql 5.6 on 12.04
+  - software-properties-common
   - python-mysqldb
+  - mysql-server

playbooks/roles/mysql/tasks/main.yml

@@ -10,18 +10,16 @@
 #  http://downloads.mysql.com/archives/mysql-5.1/mysql-5.1.62.tar.gz
 #
 ---
-
-# Install PPA for installing MySQL 5.6 on Ubuntu 12.04LTS
-- name: install ppa key
+- name: Install PPA for installing MySQL 5.6 on Ubuntu 12.04LTS
   apt_key:
-    id=E5267A6C
-    url='{{ COMMON_UBUNTU_APT_KEYSERVER }}0x14AA40EC0831756756D7F66C4F4EA0AAE5267A6C'
-    state=present
+    id: E5267A6C
+    url: '{{ COMMON_UBUNTU_APT_KEYSERVER }}0x14AA40EC0831756756D7F66C4F4EA0AAE5267A6C'
+    state: present
 
 - name: install apt repository
   apt_repository:
-    repo='deb http://ppa.launchpad.net/ondrej/mysql-5.6/ubuntu precise main'
-    update_cache=yes
+    repo: 'deb http://ppa.launchpad.net/ondrej/mysql-5.6/ubuntu precise main'
+    update_cache: yes
 
 - name: look for mysql 5.5
   shell: dpkg -L mysql-server-5.5
@@ -32,14 +30,28 @@
   when: mysql_55_installed.rc != 1
 
 - name: install mysql 56 and dependencies
-  apt: pkg={{ item }} install_recommends=yes force=yes state=present
-  with_items:
-    - software-properties-common
-    - mysql-server
-
-- name: install mysql debian packages
-  apt: pkg={{ item }} install_recommends=yes state=present
+  apt: 
+    name: "{{ item }}" 
+    install_recommends: yes 
+    force: yes 
+    state: present
   with_items: mysql_debian_pkgs
 
+- name: Ensure Anonymous user(s) does not exist
+  mysql_user: 
+    name: '' 
+    host: "{{ item }}" 
+    state: absent
+  with_items:
+    - localhost
+    - "{{ ansible_hostname }}"
+ 
+- name: Remove the test database
+  mysql_db: 
+    name: test 
+    state: absent
+
 - name: start mysql
-  service: name=mysql state=started
+  service: 
+    name: mysql 
+    state: started

playbooks/roles/mysql/tasks/remove_mysql_55.yml

@@ -7,10 +7,15 @@
 #
 
 - name: stop mysql
-  service: name=mysql state=stopped
+  service: 
+    name: mysql 
+    state: stopped
 
 - name: remove prior version of mysql
-  apt: pkg='{{ item }}' state='absent' purge='yes'
+  apt: 
+    name: "{{ item }}" 
+    state: absent 
+    purge: yes
   with_items:
     - mysql-server-5.5
     - mysql-server  
\ No newline at end of file