fix the duplicate entry of rabbitmq_refresh

playbooks/roles/edxlocal/defaults/main.yml

@@ -18,58 +18,36 @@ edxlocal_databases:
   - "{{ DISCOVERY_DEFAULT_DB_NAME | default(None) }}"
 
 edxlocal_database_users:
-  - {
-      db: "{{ ECOMMERCE_DEFAULT_DB_NAME | default(None) }}",
-      user: "{{ ECOMMERCE_DATABASES.default.USER | default(None) }}",
-      pass: "{{ ECOMMERCE_DATABASES.default.PASSWORD | default(None) }}"
-    }
-  - {
-      db: "{{ INSIGHTS_DATABASE_NAME | default(None) }}",
-      user: "{{ INSIGHTS_DATABASES.default.USER | default(None) }}",
-      pass: "{{ INSIGHTS_DATABASES.default.PASSWORD | default(None) }}"
-    }
-  - {
-      db: "{{ ORA_MYSQL_DB_NAME | default(None) }}",
-      user: "{{ ORA_MYSQL_USER | default(None) }}",
-      pass: "{{ ORA_MYSQL_PASSWORD | default(None) }}"
-    }
-  - {
-      db: "{{ XQUEUE_MYSQL_DB_NAME | default(None) }}",
-      user: "{{ XQUEUE_MYSQL_USER | default(None) }}",
-      pass: "{{ XQUEUE_MYSQL_PASSWORD | default(None) }}"
-    }
-  - {
-      db: "{{ EDXAPP_MYSQL_DB_NAME | default(None) }}",
-      user: "{{ EDXAPP_MYSQL_USER | default(None) }}",
-      pass: "{{ EDXAPP_MYSQL_PASSWORD | default(None) }}"
-    }
-  - {
-      db: "{{ EDXAPP_MYSQL_CSMH_DB_NAME | default(None) }}",
-      user: "{{ EDXAPP_MYSQL_CSMH_USER | default(None) }}",
-      pass: "{{ EDXAPP_MYSQL_CSMH_PASSWORD | default(None) }}"
-    }
-  - {
-      db: "{{ PROGRAMS_DEFAULT_DB_NAME | default(None) }}",
-      user: "{{ PROGRAMS_DATABASES.default.USER | default(None) }}",
-      pass: "{{ PROGRAMS_DATABASES.default.PASSWORD | default(None) }}"
-    }
-  - {
-      db: "{{ ANALYTICS_PIPELINE_OUTPUT_DATABASE_NAME | default(None) }}",
-      user: "{{ ANALYTICS_PIPELINE_OUTPUT_DATABASE.username }}",
-      pass: "{{ ANALYTICS_PIPELINE_OUTPUT_DATABASE.password }}"
-    }
-  - {
-      db: "{{ HIVE_METASTORE_DATABASE_NAME | default(None) }}",
-      user: "{{ HIVE_METASTORE_DATABASE.user | default(None) }}",
-      pass: "{{ HIVE_METASTORE_DATABASE.password | default(None) }}"
-    }
-  - {
-      db: "{{ CREDENTIALS_DEFAULT_DB_NAME | default(None) }}",
-      user: "{{ CREDENTIALS_MYSQL_USER | default(None) }}",
-      pass: "{{ CREDENTIALS_MYSQL_PASSWORD | default(None) }}"
-    }
-  - {
-      db: "{{ DISCOVERY_DEFAULT_DB_NAME | default(None) }}",
-      user: "{{ DISCOVERY_MYSQL_USER | default(None) }}",
-      pass: "{{ DISCOVERY_MYSQL_PASSWORD | default(None) }}"
-    }
+  - db: "{{ ECOMMERCE_DEFAULT_DB_NAME | default(None) }}"
+    user: "{{ ECOMMERCE_DATABASES.default.USER | default(None) }}"
+    pass: "{{ ECOMMERCE_DATABASES.default.PASSWORD | default(None) }}"
+  - db: "{{ INSIGHTS_DATABASE_NAME | default(None) }}"
+    user: "{{ INSIGHTS_DATABASES.default.USER | default(None) }}"
+    pass: "{{ INSIGHTS_DATABASES.default.PASSWORD | default(None) }}"
+  - db: "{{ ORA_MYSQL_DB_NAME | default(None) }}"
+    user: "{{ ORA_MYSQL_USER | default(None) }}"
+    pass: "{{ ORA_MYSQL_PASSWORD | default(None) }}"
+  - db: "{{ XQUEUE_MYSQL_DB_NAME | default(None) }}"
+    user: "{{ XQUEUE_MYSQL_USER | default(None) }}"
+    pass: "{{ XQUEUE_MYSQL_PASSWORD | default(None) }}"
+  - db: "{{ EDXAPP_MYSQL_DB_NAME | default(None) }}"
+    user: "{{ EDXAPP_MYSQL_USER | default(None) }}"
+    pass: "{{ EDXAPP_MYSQL_PASSWORD | default(None) }}"
+  - db: "{{ EDXAPP_MYSQL_CSMH_DB_NAME | default(None) }}"
+    user: "{{ EDXAPP_MYSQL_CSMH_USER | default(None) }}"
+    pass: "{{ EDXAPP_MYSQL_CSMH_PASSWORD | default(None) }}"
+  - db: "{{ PROGRAMS_DEFAULT_DB_NAME | default(None) }}"
+    user: "{{ PROGRAMS_DATABASES.default.USER | default(None) }}"
+    pass: "{{ PROGRAMS_DATABASES.default.PASSWORD | default(None) }}"
+  - db: "{{ ANALYTICS_PIPELINE_OUTPUT_DATABASE_NAME | default(None) }}"
+    user: "{{ ANALYTICS_PIPELINE_OUTPUT_DATABASE.username }}"
+    pass: "{{ ANALYTICS_PIPELINE_OUTPUT_DATABASE.password }}"
+  - db: "{{ HIVE_METASTORE_DATABASE_NAME | default(None) }}"
+    user: "{{ HIVE_METASTORE_DATABASE.user | default(None) }}"
+    pass: "{{ HIVE_METASTORE_DATABASE.password | default(None) }}"
+  - db: "{{ CREDENTIALS_DEFAULT_DB_NAME | default(None) }}"
+    user: "{{ CREDENTIALS_MYSQL_USER | default(None) }}"
+    pass: "{{ CREDENTIALS_MYSQL_PASSWORD | default(None) }}"
+  - db: "{{ DISCOVERY_DEFAULT_DB_NAME | default(None) }}"
+    user: "{{ DISCOVERY_MYSQL_USER | default(None) }}"
+    pass: "{{ DISCOVERY_MYSQL_PASSWORD | default(None) }}"

playbooks/roles/edxlocal/tasks/main.yml

@@ -3,8 +3,11 @@
 ---
 
 - name: install packages needed for single server
-  apt: pkg={{ item }} install_recommends=yes state=present
-  with_items: edxlocal_debian_pkgs
+  apt:
+    name: "{{ item }}"
+    install_recommends: yes
+    state: present
+  with_items: "{{ edxlocal_debian_pkgs }}"
 
 # TODO: Add a test to make sure mysql is running.
 

playbooks/roles/mysql/tasks/mysql.yml

@@ -49,7 +49,7 @@
     name: "{{ item }}" 
     install_recommends: yes
     state: present
-  with_items: mysql_debian_pkgs
+  with_items: "{{ mysql_debian_pkgs }}"
 
 - name: Start mysql
   service: