- 25 Apr, 2012 3 commits
-
-
Seth Vidal committed
-
Bugfix for issue #229
Michael DeHaan committed -
cocoy committed
-
- 24 Apr, 2012 34 commits
-
-
Use the $HOME env var instead of hard coding /home/<username>
Michael DeHaan committed -
Support YAML list of hosts in playbook.
Michael DeHaan committed -
Reading the docs, I was a bit confused as to how to specify multiple hosts/groups in a playbook. Being YAML, I assumed a normal YAML list would work: --- - hosts: [host1, host2] But this crashes when inventory._matches() assumes hosts is a string. This patch just checks if hosts is a list, and turns it into a string joined by ';'.jkleint committed -
runner._chain_file_module() calls .get() on error string
Michael DeHaan committed -
Chris Read committed
-
runner._return_from_module() normally returns a list (?) of `[str,bool,dict,str]`, but on error it returns `[str,bool,str,str]`. runner._chain_file_module() then tries to call .get() on the third item (`data2`), which fails when it's a string. This patch only accesses `data2` if the return value was `ok`. It might be better to return consistent types in both cases, but I'm not sure where/how else the return value is used.
jkleint committed -
handle issues when the hostlist is inadvertently set executable
Michael DeHaan committed -
git://github.com/ansible/ansible
* 'devel' of git://github.com/ansible/ansible: (2 commits) Fix tests for facter and the ansible_facts API. ...
Seth Vidal committed -
Ohai and facter modules should not use the ansible_facts API.
Michael DeHaan committed -
and/or executing it fails. This produces a nicer error message than a traceback
Seth Vidal committed -
Jeroen Hoekx committed
-
Jeroen Hoekx committed
-
Expand user in ssh identity file
Michael DeHaan committed -
Fix incorrect merge of custom-facts branch.
Michael DeHaan committed -
This fixes #216.
Jeroen Hoekx committed -
Jeroen Hoekx committed
-
Jeroen Hoekx committed
-
Michael DeHaan committed
-
Michael DeHaan committed
-
bugfix for ssh_config patch
Michael DeHaan committed -
Matt Coddington committed
-
Michael DeHaan committed
-
-
Michael DeHaan committed
-
Michael DeHaan committed
-
Michael DeHaan committed
-
changelogs yet since this isn't released yet (but 0.3 is)
Michael DeHaan committed -
Michael DeHaan committed
-
Michael DeHaan committed
-
Conflicts: lib/ansible/playbook.py lib/ansible/runner.py library/apt
Michael DeHaan committed -
Michael DeHaan committed
-
Debmake
Michael DeHaan committed
-
- 23 Apr, 2012 3 commits
-
-
Henry Graham committed
-
The basic idea is sudo /bin/sh -c 'quoted_command'. We use Paramiko's low-level API to set a timeout, get a pseudo tty, execute sudo and the (shell quoted) command atomically, wait just until sudo is ready to accept the password before sending it down the pipe, and then return the command's stdout and stderr. This should be faster, as there are no unneeded sleeps. There are no permissions issues reading the output. It will raise socket.timeout if the command takes too long. However, this is a per-read timeout, not a total execution timeout, so as long as the command is writing output and you are reading it, it will not time out. Local and non-sudo commands remain unchanged, but should probably adopt a similar approach. Since this is a significant change, it needs a lot of testing. Also, someone smarter than I should double-check the quoting and execution, since it is a security issue.
jkleint committed -
If the module result contains "ansible_facts", that will be added to the setup cache.
Jeroen Hoekx committed
-