- 02 Oct, 2015 23 commits
-
-
corrected output from default callback added new tests for no_log loops updated makefile test to check for both positive and negative occurrences of no_log
Brian Coca committed -
James Cammarata committed
-
James Cammarata committed
-
James Cammarata committed
-
Toshio Kuratomi committed
-
Abhijit Menon-Sen committed
-
Abhijit Menon-Sen committed
-
It's just s/extra_args/common_args/, but I reworded some parts to make things a bit clearer too. Closes #12335
Abhijit Menon-Sen committed -
The earlier code behaved exactly as though this default had been set, but it was actually handled as a(n unnecessary) special case inside the connection plugin, rather than set as an explicit default. If the default is overriden either in ansible.cfg or the environment, the new code will continue to work (in fact, it won't know or care, since it just uses the value set in the PlayContext). This is submitted as a separate commit for easier review to address backwards-compatibility concerns.
Abhijit Menon-Sen committed -
Using set_host_overrides() in the connection plugin to access the ssh argument variables from the inventory didn't see group_vars/host_vars settings, as noted earlier. Instead, we can set the correct values in the PlayContext, which has access to all command-line options, task settings, and variables. The only downside of doing so is that the source of the settings is no longer available in ssh.py, and therefore can't be logged. But the code is simpler, and it actually works. This change was suggested by @jimi-c in response to the FIXME in the earlier commit.
Abhijit Menon-Sen committed -
Now we have the following ways to set additional arguments: 1. [ssh_connection]ssh_args in ansible.cfg: global setting, prepended to every command line for ssh/scp/sftp. Overrides default ControlPersist settings. 2. ansible_ssh_common_args inventory variable. Appended to every command line for ssh/scp/sftp. Used in addition to ssh_args, if set above, or the default settings. 3. ansible_{sftp,scp,ssh}_extra_args inventory variables. Appended to every command line for the relevant binary only. Used in addition to #1 and #2, if set above, or the default settings. 3. Using the --ssh-common-args or --{sftp,scp,ssh}-extra-args command line options (which are overriden by #2 and #3 above). This preserves backwards compatibility (for ssh_args in ansible.cfg), but also permits global settings (e.g. ProxyCommand via _common_args) or ssh-specific options (e.g. -R via ssh_extra_args). Fixes #12576
Abhijit Menon-Sen committed -
Toshio Kuratomi committed
-
Brian Coca committed
-
should be last commit that fixes #12214
Brian Coca committed -
Brian Coca committed
-
normalized outputs to use display class cleaned up unused imports
Brian Coca committed -
Brian Coca committed
-
Fixes #12582
James Cammarata committed -
James Cammarata committed
-
James Cammarata committed
-
James Cammarata committed
-
Alphabitize retry_files_enabled and retry_files_save_path
Brian Coca committed
-
- 01 Oct, 2015 17 commits
-
-
Brian Coca committed
-
Brian Coca committed
-
Brian Coca committed
-
Brian Coca committed
-
Brian Coca committed
-
Brian Coca committed
-
Brian Coca committed
-
Greg DeKoenigsberg committed
-
Brian Coca committed
-
Document vars merging so we can push PRs against the common repo
Brian Coca committed -
Remove mysterious old cruft
James Cammarata committed -
The two lines were added in 2673eb0a and modified in 60e1a1f8, but foo is completely unused. Removing it doesn't break anything: out it goes!
Abhijit Menon-Sen committed -
Update consul integration test with http checks
James Cammarata committed -
Remove an unwanted FIXME annotation ok, confirmed we don't want to support it
Brian Coca committed -
Brian Coca committed
-
Brian Coca committed
-
Fixes #12590
James Cammarata committed
-