Fixes #7627
Fixes #7664

The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.

Fixes #7657

Fixes #7515
Fixes #7537

The etype parameter just had a copy of the default parameter documentation.
Changed it to reflect what it really is for.

directory

Fixes #7403

When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source

When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.

Also adds an integration test for the above.

Fixes #7254

- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module

Fixes #7182

The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.

now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)

Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>

I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.

Fixes #6927

This reverts commit 2bfaacd1.

Fixes #6821

This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.

Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
Application to other cloud providers would make very good sense.

Allow you to pass in arbitrary rsync options. I also added help for it, and what version it was added in.

failed: [192.168.1.2] => {"cmd": "rsync --delay-updates -FF --compress --timeout=10 --delete-after --rsh 'ssh -i /home/jjshoe/.vagrant.d/insecure_private_key -o StrictHostKeyChecking=no' --rsync-path 'sudo rsync' --out-format='<<CHANGED>>%i %n%L' /tmp/app vagrant@192.168.1.2:/home/ubuntu/app", "failed": true, "item": "", "rc": 1}
msg: rsync: --delete does not work without --recursive (-r) or --dirs (-d).
rsync error: syntax or usage error (code 1) at main.c(1453) [client=3.0.9]

passed via this paramter is not passed via shell and so all shell features
will not work.

This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.

previous operation.

else which made it try to link x2