1. 01 Jun, 2013 4 commits
  2. 31 May, 2013 33 commits
  3. 30 May, 2013 3 commits
    • Fix for #3062 additional groups should only be added once. · b537aff5
      Also consolidated duplicate groups code into one get_groups_set() method.
      Removed unused call to user_group_membership.
      Removed sorting operations on set functions cause sets are inherently unordered.
      Minor style improvements to match the rest of the code.
      
      The new function will make the order of group names passed to the system command less determistic.
      Which was already the case for modify_user_usermod() but not for other methods.
      It will also strip out duplicate group names automatically which was not always the case previously.
      trbs committed
    • authorized_key: Set manage_dir default value · 8c9cceac
      This commit fixes a bug where the authorized_key module causes
      the ~user/.ssh directory to be owned by root instead of the user,
      when the manage_dir argument is not specified.
      
      If the manage_dir argument was not specified, the module behaved as if
      manage_dir was set to false, even though it's supposed to default to
      true.
      
      This module assumed that an optional argument, with no default
      specified, will not be present in the module.params dictionary.
      
      What actually seems to happen is that the argument does appear in
      the module.params dictionary with a value of None.
      
      The upside is that this line was evaluating to None instead of
      true:
      
          manage_dir = params.get("manage_dir", True)
      
      I fixed the problem in this particular module by explicitly specifying
      the default value for the manage_dir arugment. But if this bug
      occurred because of a change in behavior in AnsibleModule, then other
      modules may be broken as well.
      Lorin Hochstein committed