1. 11 Apr, 2013 1 commit
    • Prevent premature substitution of variables into tasks · 377bc313
      As documented in #2623, early variable substitution causes when_
      tests to fail and possibly other side effects.
      
      I can see the reason for this early substitution, likely introduced
      in 1dfe60a6, to allow many playbook parameters to be templated.
      This is a valid goal, but the recursive nature of the utils.template
      function means that it goes too far.
      
      At this point removing tasks from the list of parameters to be
      substituted seems sufficient to make my tests pass. It may be the
      case that other parameters should be excluded, but I suspect not.
      
      Adding a test case. I would prefer to analyse not just the aggregate
      statistics but also whether the results are as expected - I can't
      see an easy way to do that with the available callbacks at present.
      willthames committed
  2. 10 Apr, 2013 1 commit
  3. 08 Apr, 2013 1 commit
    • Test case and fix for shlex.split unicode bug · 9d87733f
      When operating on a unicode string in python 2.6, shlex.split returns
      a result that does not work with the file constructor.
      
      To reproduce this requires a task include that is templated (this is
      because the templated string is a unicode result, whereas a non-
      templated string is a non-unicode string)
      
          [will@centos6.3] $ python
          Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23)
          [GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2
          Type "help", "copyright", "credits" or "license" for more information.
          >>> import shlex
          >>> shlex.split(u'abc')
          ['a\x00\x00\x00b\x00\x00\x00c\x00\x00\x00']
      
          [will@fedora17] $ python
          Python 2.7.3 (default, Jul 24 2012, 10:05:38)
          [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2
          Type "help", "copyright", "credits" or "license" for more information.
          >>> import shlex
          >>> shlex.split(u'abc')
          ['abc']
      
      The proposed fix (coercing the include parameters to string before the
      shlex.split) may not be ideal but it does fix the bug for my test case.
      willthames committed
  4. 06 Apr, 2013 1 commit
  5. 05 Apr, 2013 1 commit
  6. 03 Apr, 2013 1 commit
  7. 10 Mar, 2013 1 commit
  8. 09 Jan, 2013 1 commit
  9. 19 Nov, 2012 2 commits
  10. 13 Nov, 2012 3 commits
  11. 09 Nov, 2012 1 commit
  12. 07 Nov, 2012 1 commit
  13. 06 Nov, 2012 1 commit
  14. 01 Nov, 2012 1 commit
  15. 26 Oct, 2012 1 commit
  16. 21 Oct, 2012 1 commit
  17. 19 Sep, 2012 2 commits
  18. 17 Sep, 2012 1 commit
  19. 11 Sep, 2012 1 commit
  20. 29 Aug, 2012 1 commit
  21. 14 Aug, 2012 1 commit
  22. 10 Aug, 2012 1 commit
  23. 07 Aug, 2012 1 commit
  24. 01 Aug, 2012 2 commits
  25. 15 Jul, 2012 1 commit
  26. 14 Jul, 2012 1 commit
  27. 20 Jun, 2012 1 commit
    • Remove the -D module debug flag, which no longer is functional due to sudo pty… · efac68b6
      Remove the -D module debug flag, which no longer is functional due to sudo pty requirements, and replace with -v/--verbose.
      
      This flag will show playbook output from non-failing commands.  -v is also added to /usr/bin/ansible, but not  yet used.
      
      I also gutted some internals code dealing with 'invocations' which allowed the callback to know what module invoked
      it.  This is not something 0.5 does or needed, so callbacks have been simplified.
      Michael DeHaan committed
  28. 31 May, 2012 1 commit
  29. 10 May, 2012 1 commit
  30. 11 May, 2012 1 commit
  31. 01 May, 2012 1 commit
  32. 26 Apr, 2012 1 commit
  33. 20 Apr, 2012 1 commit
  34. 17 Apr, 2012 1 commit
  35. 12 Apr, 2012 1 commit