Commit e34eaa42 by Shaun Zinck

pkgin: change install/remove to not use return code of pkgin

pkgin always returns 0 so can't be used to tell if the install or remove
worked.  Instead this just queries the installed packages after
performing an operation.
parent 4a9201ad
...@@ -82,7 +82,7 @@ def remove_packages(module, packages): ...@@ -82,7 +82,7 @@ def remove_packages(module, packages):
rc = os.system("%s -y remove %s" % (PKGIN_PATH, package)) rc = os.system("%s -y remove %s" % (PKGIN_PATH, package))
if rc != 0: if query_package(module, package):
module.fail_json(msg="failed to remove %s" % (package)) module.fail_json(msg="failed to remove %s" % (package))
remove_c += 1 remove_c += 1
...@@ -104,7 +104,7 @@ def install_packages(module, packages): ...@@ -104,7 +104,7 @@ def install_packages(module, packages):
rc = os.system("%s -y install %s" % (PKGIN_PATH, package)) rc = os.system("%s -y install %s" % (PKGIN_PATH, package))
if rc != 0: if not query_package(module, package):
module.fail_json(msg="failed to install %s" % (package)) module.fail_json(msg="failed to install %s" % (package))
install_c += 1 install_c += 1
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment