Fixing broken patch 20957a1b

Also adds integration tests for nested includes with conditionals

lib/ansible/playbook/play.py

@@ -538,11 +538,10 @@ class Play(object):
                     elif k.startswith("when_"):
                         utils.deprecated("\"when_<criteria>:\" is a removed deprecated feature, use the simplified 'when:' conditional directly", None, removed=True)
                     elif k == 'when':
-                        if type(x[k]) is str:
-                            included_additional_conditions.insert(0, x[k])
+                        if isinstance(x[k], (basestring, bool)):
+                            included_additional_conditions.append(x[k])
                         elif type(x[k]) is list:
-                            for i in x[k]:
-                                included_additional_conditions.insert(0, i)
+                            included_additional_conditions.extend(x[k])
                     elif k in ("include", "vars", "default_vars", "sudo", "sudo_user", "role_name", "no_log"):
                         continue
                     else:

test/integration/roles/test_good_parsing/tasks/main.yml

@@ -164,3 +164,11 @@
       - result.invocation.module_name == "debug"
       - result.msg == "this should be debugged"
 
+- name: test conditional includes
+  include: test_include_conditional.yml
+  when: false
+
+- name: assert the nested include from test_include_conditional was not set
+  assert:
+    that:
+      - nested_include_var is undefined

test/integration/roles/test_good_parsing/tasks/test_include_conditional.yml

+- include: test_include_nested.yml

test/integration/roles/test_good_parsing/tasks/test_include_nested.yml

+- name: set the nested include fact
+  set_fact: nested_include_var=1