Commit db92301b by Michael J. Schultz

cloud/elasticache: Ensure self.data is iterable

- self.data['SecurityGroups'] can return None causing traceback, if that
  is the case fallback to an empty list
parent b0556ab1
...@@ -395,7 +395,8 @@ class ElastiCacheManager(object): ...@@ -395,7 +395,8 @@ class ElastiCacheManager(object):
# check vpc security groups # check vpc security groups
vpc_security_groups = [] vpc_security_groups = []
for sg in self.data['SecurityGroups']: security_groups = self.data['SecurityGroups'] or []
for sg in security_groups:
vpc_security_groups.append(sg['SecurityGroupId']) vpc_security_groups.append(sg['SecurityGroupId'])
if set(vpc_security_groups) - set(self.security_group_ids): if set(vpc_security_groups) - set(self.security_group_ids):
return True return True
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment