Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
ansible
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenEdx
ansible
Commits
b43939df
Commit
b43939df
authored
Sep 22, 2015
by
Rene Moser
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
cloudstack: make tags handling idempotence
Credits to @jeffersongirao, who provided the patch.
parent
efd122c2
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
37 additions
and
38 deletions
+37
-38
lib/ansible/module_utils/cloudstack.py
+37
-38
No files found.
lib/ansible/module_utils/cloudstack.py
View file @
b43939df
...
@@ -90,6 +90,7 @@ class AnsibleCloudStack(object):
...
@@ -90,6 +90,7 @@ class AnsibleCloudStack(object):
self
.
os_type
=
None
self
.
os_type
=
None
self
.
hypervisor
=
None
self
.
hypervisor
=
None
self
.
capabilities
=
None
self
.
capabilities
=
None
self
.
tags
=
None
def
_connect
(
self
):
def
_connect
(
self
):
...
@@ -319,47 +320,44 @@ class AnsibleCloudStack(object):
...
@@ -319,47 +320,44 @@ class AnsibleCloudStack(object):
def
get_tags
(
self
,
resource
=
None
):
def
get_tags
(
self
,
resource
=
None
):
existing_tags
=
self
.
cs
.
listTags
(
resourceid
=
resource
[
'id'
])
if
not
self
.
tags
:
if
existing_tags
:
args
=
{}
return
existing_tags
[
'tag'
]
args
[
'projectid'
]
=
self
.
get_project
(
key
=
'id'
)
return
[]
args
[
'account'
]
=
self
.
get_account
(
key
=
'name'
)
args
[
'domainid'
]
=
self
.
get_domain
(
key
=
'id'
)
args
[
'resourceid'
]
=
resource
[
'id'
]
def
_delete_tags
(
self
,
resource
,
resource_type
,
tags
):
response
=
self
.
cs
.
listTags
(
**
args
)
existing_tags
=
resource
[
'tags'
]
self
.
tags
=
response
.
get
(
'tag'
,
[])
tags_to_delete
=
[]
for
existing_tag
in
existing_tags
:
existing_tags
=
[]
if
existing_tag
[
'key'
]
in
tags
:
if
self
.
tags
:
if
existing_tag
[
'value'
]
!=
tags
[
key
]:
for
tag
in
self
.
tags
:
tags_to_delete
.
append
(
existing_tag
)
existing_tags
.
append
({
'key'
:
tag
[
'key'
],
'value'
:
tag
[
'value'
]})
else
:
return
existing_tags
tags_to_delete
.
append
(
existing_tag
)
if
tags_to_delete
:
def
_process_tags
(
self
,
resource
,
resource_type
,
tags
,
operation
=
"create"
):
if
tags
:
self
.
result
[
'changed'
]
=
True
self
.
result
[
'changed'
]
=
True
if
not
self
.
module
.
check_mode
:
if
not
self
.
module
.
check_mode
:
args
=
{}
args
=
{}
args
[
'resourceids'
]
=
resource
[
'id'
]
args
[
'resourceids'
]
=
resource
[
'id'
]
args
[
'resourcetype'
]
=
resource_type
args
[
'resourcetype'
]
=
resource_type
args
[
'tags'
]
=
tags_to_delete
args
[
'tags'
]
=
tags
self
.
cs
.
deleteTags
(
**
args
)
if
operation
==
"create"
:
self
.
cs
.
createTags
(
**
args
)
else
:
def
_create_tags
(
self
,
resource
,
resource_type
,
tags
):
self
.
cs
.
deleteTags
(
**
args
)
tags_to_create
=
[]
for
i
,
tag_entry
in
enumerate
(
tags
):
tag
=
{
def
_tags_that_should_exist_or_be_updated
(
self
,
resource
,
tags
):
'key'
:
tag_entry
[
'key'
],
existing_tags
=
self
.
get_tags
(
resource
)
'value'
:
tag_entry
[
'value'
],
return
[
tag
for
tag
in
tags
if
tag
not
in
existing_tags
]
}
tags_to_create
.
append
(
tag
)
if
tags_to_create
:
def
_tags_that_should_not_exist
(
self
,
resource
,
tags
):
self
.
result
[
'changed'
]
=
True
existing_tags
=
self
.
get_tags
(
resource
)
if
not
self
.
module
.
check_mode
:
return
[
tag
for
tag
in
existing_tags
if
tag
not
in
tags
]
args
=
{}
args
[
'resourceids'
]
=
resource
[
'id'
]
args
[
'resourcetype'
]
=
resource_type
args
[
'tags'
]
=
tags_to_create
self
.
cs
.
createTags
(
**
args
)
def
ensure_tags
(
self
,
resource
,
resource_type
=
None
):
def
ensure_tags
(
self
,
resource
,
resource_type
=
None
):
...
@@ -369,8 +367,9 @@ class AnsibleCloudStack(object):
...
@@ -369,8 +367,9 @@ class AnsibleCloudStack(object):
if
'tags'
in
resource
:
if
'tags'
in
resource
:
tags
=
self
.
module
.
params
.
get
(
'tags'
)
tags
=
self
.
module
.
params
.
get
(
'tags'
)
if
tags
is
not
None
:
if
tags
is
not
None
:
self
.
_delete_tags
(
resource
,
resource_type
,
tags
)
self
.
_process_tags
(
resource
,
resource_type
,
self
.
_tags_that_should_exist_or_be_updated
(
resource
,
tags
))
self
.
_create_tags
(
resource
,
resource_type
,
tags
)
self
.
_process_tags
(
resource
,
resource_type
,
self
.
_tags_that_should_not_exist
(
resource
,
tags
),
operation
=
"delete"
)
self
.
tags
=
None
resource
[
'tags'
]
=
self
.
get_tags
(
resource
)
resource
[
'tags'
]
=
self
.
get_tags
(
resource
)
return
resource
return
resource
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment