Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
ansible
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenEdx
ansible
Commits
a591582b
Commit
a591582b
authored
Sep 26, 2015
by
Brian Coca
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #12530 from amenonsen/fixups
Update outdated comment
parents
b757798f
8251ab2e
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
7 deletions
+8
-7
lib/ansible/inventory/ini.py
+1
-2
lib/ansible/playbook/play_context.py
+7
-5
No files found.
lib/ansible/inventory/ini.py
View file @
a591582b
...
@@ -352,8 +352,7 @@ class InventoryParser(object):
...
@@ -352,8 +352,7 @@ class InventoryParser(object):
# FIXME: What are the real restrictions on group names, or rather, what
# FIXME: What are the real restrictions on group names, or rather, what
# should they be? At the moment, they must be non-empty sequences of non
# should they be? At the moment, they must be non-empty sequences of non
# whitespace characters excluding ':' and ']', but we should define more
# whitespace characters excluding ':' and ']', but we should define more
# precise rules in order to support better diagnostics. The same applies
# precise rules in order to support better diagnostics.
# to hostnames. It seems sensible for them both to follow DNS rules.
self
.
patterns
[
'groupname'
]
=
re
.
compile
(
self
.
patterns
[
'groupname'
]
=
re
.
compile
(
r'''^
r'''^
...
...
lib/ansible/playbook/play_context.py
View file @
a591582b
...
@@ -356,11 +356,13 @@ class PlayContext(Base):
...
@@ -356,11 +356,13 @@ class PlayContext(Base):
''
''
if
self
.
become_method
==
'sudo'
:
if
self
.
become_method
==
'sudo'
:
# Rather than detect if sudo wants a password this time, -k makes sudo always ask for
# If we have a password, we run sudo with a randomly-generated
# a password if one is required. Passing a quoted compound command to sudo (or sudo -s)
# prompt set using -p. Otherwise we run it with -n, which makes
# directly doesn't work, so we shellquote it with pipes.quote() and pass the quoted
# it fail if it would have prompted for a password.
# string to the user's shell. We loop reading output until we see the randomly-generated
#
# sudo prompt set with the -p option.
# Passing a quoted compound command to sudo (or sudo -s)
# directly doesn't work, so we shellquote it with pipes.quote()
# and pass the quoted string to the user's shell.
# force quick error if password is required but not supplied, should prevent sudo hangs.
# force quick error if password is required but not supplied, should prevent sudo hangs.
if
self
.
become_pass
:
if
self
.
become_pass
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment