Commit 99746d4a by Ali Asad Lotia

Indicate thirsty argument required if dest is dir.

The check for the destination being a directory is now done before
checking if the file exists, that way the user is informed that the
thirsty argument is required.
parent 16bf3e15
......@@ -145,11 +145,10 @@ def main():
thirsty = module.boolean(module.params['thirsty'])
if not thirsty:
if os.path.exists(dest):
module.exit_json(msg="file already exists", changed=False)
if os.path.isdir(dest):
module.fail_json(msg="non-thirsty mode needs a filename for a destination, not a directory")
if os.path.exists(dest):
module.exit_json(msg="file already exists", changed=False)
# download to tmpsrc
tmpsrc, info = url_get(module, url, dest)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment