lists => frozenset as we're only using them in membership checks

lib/ansible/playbook/play.py

@@ -43,13 +43,13 @@ class Play(object):
 
     # to catch typos and so forth -- these are userland names
     # and don't line up 1:1 with how they are stored
-    VALID_KEYS = [
+    VALID_KEYS = frozenset((
        'hosts', 'name', 'vars', 'vars_prompt', 'vars_files',
        'tasks', 'handlers', 'remote_user', 'user', 'port', 'include', 'accelerate', 'accelerate_port', 'accelerate_ipv6',
        'sudo', 'sudo_user', 'connection', 'tags', 'gather_facts', 'serial',
        'any_errors_fatal', 'roles', 'role_names', 'pre_tasks', 'post_tasks', 'max_fail_percentage',
        'su', 'su_user', 'vault_password', 'no_log', 'environment',
-    ]
+    ))
 
     # *************************************************
 

lib/ansible/playbook/task.py

@@ -36,14 +36,14 @@ class Task(object):
     ]
 
     # to prevent typos and such
-    VALID_KEYS = [
+    VALID_KEYS = frozenset((
          'name', 'meta', 'action', 'when', 'async', 'poll', 'notify',
          'first_available_file', 'include', 'tags', 'register', 'ignore_errors',
          'delegate_to', 'local_action', 'transport', 'remote_user', 'sudo', 'sudo_user',
          'sudo_pass', 'when', 'connection', 'environment', 'args',
          'any_errors_fatal', 'changed_when', 'failed_when', 'always_run', 'delay', 'retries', 'until',
          'su', 'su_user', 'su_pass', 'no_log', 'run_once',
-    ]
+    ))
 
     def __init__(self, play, ds, module_vars=None, play_vars=None, play_file_vars=None, role_vars=None, role_params=None, default_vars=None, additional_conditions=None, role_name=None):
         ''' constructor loads from a task or handler datastructure '''