Merge pull request #1776 from junegunn/inventory-group-var-ws

Allows whitespaces around assignment operators when defining group variables

lib/ansible/inventory/ini.py

@@ -24,6 +24,7 @@ from ansible.inventory.expand_hosts import detect_range
 from ansible.inventory.expand_hosts import expand_hostname_range
 from ansible import errors
 import shlex
+import re
 
 class InventoryParser(object):
     """
@@ -163,5 +164,10 @@ class InventoryParser(object):
                 if line.find("=") == -1:
                     raise errors.AnsibleError("variables assigned to group must be in key=value form")
                 else:
-                    (k,v) = line.split("=",1)
-                    group.set_variable(k,v)
+                    (k, v) = [e.strip() for e in line.split("=", 1)]
+                    # When the value is a single-quoted or double-quoted string
+                    if re.match(r"^(['\"]).*\1$", v):
+                        # Unquote the string
+                        group.set_variable(k, re.sub(r"^['\"]|['\"]$", '', v))
+                    else:
+                        group.set_variable(k, v)

test/TestInventory.py

@@ -142,7 +142,9 @@ class TestInventory(unittest.TestCase):
         print vars
 
         expected = dict(
-            a='1', b='2', c='3', d='10002', rga='1', rgb='2', rgc='3',
+            a='1', b='2', c='3', d='10002', e='10003', f='10004 != 10005',
+            g='  g  ', h='  h  ', i="'  i  \"", j='"  j',
+            rga='1', rgb='2', rgc='3',
             inventory_hostname='rtp_a', inventory_hostname_short='rtp_a',
             group_names=[ 'eastcoast', 'nc', 'redundantgroup', 'redundantgroup2', 'redundantgroup3', 'rtp', 'us' ]
         )

test/complex_hosts

@@ -34,6 +34,12 @@ rgc=3
 b=10000
 c=10001
 d=10002
+e =   10003
+ f =  10004 != 10005
+  g = "  g  "
+   h = '  h  '
+    i = '  i  "
+    j  = "  j  
 
 [rtp]
 rtp_a