Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
ansible
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenEdx
ansible
Commits
49807877
Commit
49807877
authored
Mar 18, 2014
by
James Tanner
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes #6550 Use shell for pipe lookup subprocess.popen calls
parent
3f5440f7
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
1 deletions
+12
-1
lib/ansible/runner/lookup_plugins/pipe.py
+12
-1
No files found.
lib/ansible/runner/lookup_plugins/pipe.py
View file @
49807877
...
...
@@ -32,7 +32,18 @@ class LookupModule(object):
ret
=
[]
for
term
in
terms
:
p
=
subprocess
.
Popen
(
term
,
cwd
=
self
.
basedir
,
shell
=
False
,
stdin
=
subprocess
.
PIPE
,
stdout
=
subprocess
.
PIPE
)
'''
http://docs.python.org/2/library/subprocess.html#popen-constructor
The shell argument (which defaults to False) specifies whether to use the
shell as the program to execute. If shell is True, it is recommended to pass
args as a string rather than as a sequence
https://github.com/ansible/ansible/issues/6550
'''
term
=
str
(
term
)
p
=
subprocess
.
Popen
(
term
,
cwd
=
self
.
basedir
,
shell
=
True
,
stdin
=
subprocess
.
PIPE
,
stdout
=
subprocess
.
PIPE
)
(
stdout
,
stderr
)
=
p
.
communicate
()
if
p
.
returncode
==
0
:
ret
.
append
(
stdout
.
decode
(
"utf-8"
)
.
rstrip
())
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment