Commit 1a7a779e by Sharif Olorin Committed by Michael DeHaan

Handle SSH failures when creating remote tmpdir

Bail out if the SSH command fails rather than continuing with an
empty tmp variable.
parent f938bc66
......@@ -719,7 +719,14 @@ class Runner(object):
cmd += ' && echo %s' % basetmp
result = self._low_level_exec_command(conn, cmd, None, sudoable=False)
if result['rc'] != 0:
raise errors.AnsibleError('could not create temporary directory: '
'SSH exited with return code %d' % result['rc'])
rc = utils.last_non_blank_line(result['stdout']).strip() + '/'
# Catch any other failure conditions here; files should never be
# written directly to /.
if rc == '/':
raise errors.AnsibleError('refusing to use / as a temporary directory.')
return rc
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment