When sudoing to another user, the umask may be set such that the next user might…

When sudoing to another user, the umask may be set such that the next user might not be able to read/execute the file. Deal with this.

When sudoing to another user, the umask may be set such that the next user might…
When sudoing to another user, the umask may be set such that the next user might not be able to read/execute the file. Deal with this.
17be5537 · Michael DeHaan · fcdc281c · 17be5537
Commit 17be5537 authored Jul 28, 2012 by Michael DeHaan
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletions

lib/ansible/runner/__init__.py
+5 -1

No files found.
--- a/lib/ansible/runner/__init__.py
+++ b/lib/ansible/runner/__init__.py
@@ -210,7 +210,11 @@ class Runner(object):
            args = utils.jsonify(args,format=True)

        (remote_module_path, is_new_style) = self._copy_module(conn, tmp, module_name, inject)
-        self._low_level_exec_command(conn, "chmod +x %s" % remote_module_path, tmp)
+        cmd = "chmod +x %s" % remote_module_path
+        if self.sudo and self.sudo_user != 'root':
+            # deal with possible umask issues once sudo'ed to other user
+            cmd = "chmod 555 %s" % remote_module_path
+        self._low_level_exec_command(conn, cmd, tmp)

        cmd = ""
        if not is_new_style: