Commit fe6ed085 by cahrens

Code review feedback.

parent d11c92d7
...@@ -145,7 +145,7 @@ def upload_asset(request, org, course, coursename): ...@@ -145,7 +145,7 @@ def upload_asset(request, org, course, coursename):
return JsonResponse(response_payload) return JsonResponse(response_payload)
@require_http_methods("DELETE") @require_http_methods(("DELETE",))
@login_required @login_required
@ensure_csrf_cookie @ensure_csrf_cookie
def update_asset(request, org, course, name, asset_id): def update_asset(request, org, course, name, asset_id):
...@@ -158,7 +158,6 @@ def update_asset(request, org, course, name, asset_id): ...@@ -158,7 +158,6 @@ def update_asset(request, org, course, name, asset_id):
""" """
get_location_and_verify_access(request, org, course, name) get_location_and_verify_access(request, org, course, name)
if request.method == 'DELETE':
# make sure the location is valid # make sure the location is valid
try: try:
loc = StaticContent.get_location_from_path(asset_id) loc = StaticContent.get_location_from_path(asset_id)
......
...@@ -10,7 +10,7 @@ CMS.Views.Assets = Backbone.View.extend({ ...@@ -10,7 +10,7 @@ CMS.Views.Assets = Backbone.View.extend({
this.$el.empty(); this.$el.empty();
var self = this; var self = this;
_.each(this.collection.models, this.collection.each(
function(asset) { function(asset) {
var view = new CMS.Views.Asset({model: asset}); var view = new CMS.Views.Asset({model: asset});
self.$el.append(view.render().el); self.$el.append(view.render().el);
......
...@@ -76,7 +76,7 @@ urlpatterns = ('', # nopep8 ...@@ -76,7 +76,7 @@ urlpatterns = ('', # nopep8
url(r'^(?P<org>[^/]+)/(?P<course>[^/]+)/assets/(?P<name>[^/]+)$', url(r'^(?P<org>[^/]+)/(?P<course>[^/]+)/assets/(?P<name>[^/]+)$',
'contentstore.views.asset_index', name='asset_index'), 'contentstore.views.asset_index', name='asset_index'),
url(r'^(?P<org>[^/]+)/(?P<course>[^/]+)/assets/(?P<name>[^/]+)/update/(?P<asset_id>.+)?.*$', url(r'^(?P<org>[^/]+)/(?P<course>[^/]+)/assets/(?P<name>[^/]+)/(?P<asset_id>.+)?.*$',
'contentstore.views.assets.update_asset', name='update_asset'), 'contentstore.views.assets.update_asset', name='update_asset'),
url(r'^(?P<org>[^/]+)/(?P<course>[^/]+)/textbooks/(?P<name>[^/]+)$', url(r'^(?P<org>[^/]+)/(?P<course>[^/]+)/textbooks/(?P<name>[^/]+)$',
'contentstore.views.textbook_index', name='textbook_index'), 'contentstore.views.textbook_index', name='textbook_index'),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment