Commit e75f2733 by Andy Armstrong

Apply Sarina's code review suggestions

parent 6d08a0b4
...@@ -33,10 +33,10 @@ define(["underscore", "gettext", "js/views/baseview"], function(_, gettext, Base ...@@ -33,10 +33,10 @@ define(["underscore", "gettext", "js/views/baseview"], function(_, gettext, Base
messageHtml: function() { messageHtml: function() {
var message; var message;
if (this.view.collection.sortDirection === 'asc') { if (this.view.collection.sortDirection === 'asc') {
// Translators: sample result: "Showing 0-9 out of 25, sorted by name ascending" // Translators: sample result: "Showing 0-9 out of 25 total, sorted by Date Added ascending"
message = gettext('Showing %(current_item_range)s out of %(total_items_count)s, sorted by %(sort_name)s ascending'); message = gettext('Showing %(current_item_range)s out of %(total_items_count)s, sorted by %(sort_name)s ascending');
} else { } else {
// Translators: sample result: "Showing 0-9 out of 25, sorted by name descending" // Translators: sample result: "Showing 0-9 out of 25 total, sorted by Date Added descending"
message = gettext('Showing %(current_item_range)s out of %(total_items_count)s, sorted by %(sort_name)s descending'); message = gettext('Showing %(current_item_range)s out of %(total_items_count)s, sorted by %(sort_name)s descending');
} }
return '<p>' + interpolate(message, { return '<p>' + interpolate(message, {
...@@ -60,6 +60,7 @@ define(["underscore", "gettext", "js/views/baseview"], function(_, gettext, Base ...@@ -60,6 +60,7 @@ define(["underscore", "gettext", "js/views/baseview"], function(_, gettext, Base
totalItemsCountLabel: function() { totalItemsCountLabel: function() {
var totalItemsLabel; var totalItemsLabel;
// Translators: turns into "25 total" to be used in other sentences, e.g. "Showing 0-9 out of 25 total".
totalItemsLabel = interpolate(gettext('%(total_items)s total'), { totalItemsLabel = interpolate(gettext('%(total_items)s total'), {
total_items: this.view.collection.totalCount total_items: this.view.collection.totalCount
}, true); }, true);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment