Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
cb5e76ee
Commit
cb5e76ee
authored
Nov 03, 2017
by
Omar Al-Ithawi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Hide the create library for non-staff users when DISABLE_COURSE_CREATION
parent
19c2faee
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
1 deletions
+11
-1
cms/djangoapps/contentstore/views/library.py
+1
-1
cms/djangoapps/contentstore/views/tests/test_library.py
+10
-0
No files found.
cms/djangoapps/contentstore/views/library.py
View file @
cb5e76ee
...
...
@@ -58,7 +58,7 @@ def get_library_creator_status(user):
elif
settings
.
FEATURES
.
get
(
'ENABLE_CREATOR_GROUP'
,
False
):
return
get_course_creator_status
(
user
)
==
'granted'
else
:
return
True
return
not
settings
.
FEATURES
.
get
(
'DISABLE_COURSE_CREATION'
,
False
)
@login_required
...
...
cms/djangoapps/contentstore/views/tests/test_library.py
View file @
cb5e76ee
...
...
@@ -28,6 +28,7 @@ def make_url_for_lib(key):
@ddt.ddt
@mock.patch.dict
(
'django.conf.settings.FEATURES'
,
{
'DISABLE_COURSE_CREATION'
:
False
})
class
UnitTestLibraries
(
CourseTestCase
):
"""
Unit tests for library views
...
...
@@ -63,6 +64,15 @@ class UnitTestLibraries(CourseTestCase):
_
,
nostaff_user
=
self
.
create_non_staff_authed_user_client
()
self
.
assertEqual
(
get_library_creator_status
(
nostaff_user
),
True
)
@mock.patch.dict
(
'django.conf.settings.FEATURES'
,
{
'DISABLE_COURSE_CREATION'
:
True
})
@mock.patch
(
"contentstore.views.library.LIBRARIES_ENABLED"
,
True
)
def
test_library_creator_status_with_no_course_creator_role_and_disabled_nonstaff_course_creation
(
self
):
"""
Ensure that `DISABLE_COURSE_CREATION` feature works with libraries as well.
"""
_
,
nostaff_user
=
self
.
create_non_staff_authed_user_client
()
self
.
assertFalse
(
get_library_creator_status
(
nostaff_user
))
@patch
(
"contentstore.views.library.LIBRARIES_ENABLED"
,
False
)
def
test_with_libraries_disabled
(
self
):
"""
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment