pr feedback

common/test/acceptance/pages/lms/dashboard.py

@@ -174,14 +174,14 @@ class DashboardPage(PageObject):
         """
         return self.q(css='.dropdown-menu li a').text
 
-    def click_account_settings_link(self):
+        def click_my_profile_link(self):
             """
-        Click on `Account` link.
+            Click on `Profile` link.
             """
             self.q(css='.dropdown-menu li a').nth(1).click()
 
-    def click_my_profile_link(self):
+    def click_account_settings_link(self):
         """
-        Click on `Profile` link.
+        Click on `Account` link.
         """
         self.q(css='.dropdown-menu li a').nth(2).click()

lms/templates/navigation-edx.html

@@ -82,8 +82,8 @@ site_status_msg = get_site_status_msg(course_id)
         <ul class="dropdown-menu" aria-label="More Options" role="menu">
           <%block name="navigation_dropdown_menu_links" >
             <li><a href="${reverse('dashboard')}">${_("Dashboard")}</a></li>
-            <li><a href="${reverse('account_settings')}">${_("Account")}</a></li>
             <li><a href="${reverse('learner_profile', kwargs={'username': user.username})}">${_("Profile")}</a></li>
+            <li><a href="${reverse('account_settings')}">${_("Account")}</a></li>
           </%block>
           <li><a href="${reverse('logout')}" role="menuitem">${_("Sign Out")}</a></li>
         </ul>

lms/templates/navigation.html

@@ -90,8 +90,8 @@ site_status_msg = get_site_status_msg(course_id)
         <ul class="dropdown-menu" aria-label="More Options" role="menu">
           <%block name="navigation_dropdown_menu_links" >
             <li><a href="${reverse('dashboard')}">${_("Dashboard")}</a></li>
-            <li><a href="${reverse('account_settings')}">${_("Account")}</a></li>
             <li><a href="${reverse('learner_profile', kwargs={'username': user.username})}">${_("Profile")}</a></li>
+            <li><a href="${reverse('account_settings')}">${_("Account")}</a></li>
           </%block>
           <li><a href="${reverse('logout')}" role="menuitem">${_("Sign Out")}</a></li>
         </ul>