Comprehensive Theming: re-organizing/minor simplifying of existing LMS Sass variables

common/lib/xmodule/xmodule/css/capa/display.scss

@@ -111,7 +111,7 @@ iframe[seamless]{
 }
 
 .inline-error {
-  color: darken($error-red, 11%);
+  color: darken($error-color, 11%);
 }
 
 div.problem-progress {
@@ -967,8 +967,8 @@ div.problem {
 
   div.capa_reset {
     padding: 25px;
-    border: 1px solid $error-red;
-    background-color: lighten($error-red, 25%);
+    border: 1px solid $error-color;
+    background-color: lighten($error-color, 25%);
     border-radius: 3px;
     font-size: 1em;
     margin-top: $baseline/2;

common/lib/xmodule/xmodule/css/combinedopenended/display.scss

@@ -35,7 +35,7 @@ div.name{
 }
 
 .inline-error {
-  color: darken($error-red, 10%);
+  color: darken($error-color, 10%);
 }
 
 section.combined-open-ended {
@@ -863,9 +863,9 @@ section.open-ended-child {
     margin-top: ($baseline/2);
     margin-bottom: ($baseline/2);
     padding: 25px;
-    border: 1px solid $error-red;
+    border: 1px solid $error-color;
     border-radius: 3px;
-    background-color: lighten($error-red, 25%);
+    background-color: lighten($error-color, 25%);
     font-size: 1em;
   }
 

lms/static/sass/base/_extends.scss

@@ -68,7 +68,7 @@
 
 //Styles for Error messages
 %error-message-colors {
-  background: $error-red;
+  background: $error-color;
   border: 1px solid rgb(202, 17, 17);
   color: rgb(143, 14, 14);
 }

lms/static/sass/course/courseware/_courseware.scss

@@ -614,7 +614,7 @@ div.course-wrapper {
 
     div.staff_actions {
       p.error {
-        color: $error-red
+        color: $error-color
       }
       p.success {
         color: $success-color;

lms/static/sass/course/instructor/_instructor_2.scss

@@ -137,12 +137,12 @@
   .request-response-error {
     margin: 0;
     padding-bottom: ($baseline);
-    color: $error-red;
+    color: $error-color;
   }
 
   .display-errors {
     line-height: 3em;
-    color: $error-red;
+    color: $error-color;
   }
 
   .slickgrid {

lms/static/sass/discussion/views/_create-edit-post.scss

@@ -180,7 +180,7 @@
     margin-bottom: $baseline;
     border-radius: 3px;
     padding: 0;
-    background: $error-red;
+    background: $error-color;
     box-shadow: 0 1px 2px rgba(0, 0, 0, 0.3) inset, 0 1px 0 rgba(255, 255, 255, .2);
     color: $white;
     list-style: none;

lms/static/sass/multicourse/_course_about.scss

@@ -159,7 +159,7 @@
           }
 
           #register_error {
-            background: $error-red;
+            background: $error-color;
             border: 1px solid rgb(202, 17, 17);
             color: rgb(143, 14, 14);
             display: none;

lms/static/sass/views/_teams.scss

@@ -723,11 +723,11 @@
 
     .u-field.error {
       input, textarea {
-        border-color: $danger-red;
+        border-color: $error-color;
       }
 
       .u-field-message-help, .u-field-description-message {
-        color: $danger-red !important;
+        color: $error-color !important;
       }
     }