From 98df2336f39231edf36337ea701a2e8f9242ac27 Mon Sep 17 00:00:00 2001
From: Usman Khalid <2200617@gmail.com>
Date: Thu, 3 Sep 2015 22:14:34 +0500
Subject: [PATCH] Upgrade to django-pipeline v.1.5.3.

TNL-3137
---
 cms/envs/acceptance.py                      |  4 ++++
 cms/envs/common.py                          |  2 ++
 cms/envs/devstack.py                        |  1 +
 cms/envs/test.py                            |  1 -
 common/djangoapps/pipeline_mako/__init__.py |  4 ++--
 lms/envs/acceptance.py                      |  4 ++++
 lms/envs/aws.py                             |  3 ---
 lms/envs/bok_choy.py                        |  3 +++
 lms/envs/common.py                          |  5 +++--
 lms/envs/devstack.py                        |  1 +
 lms/envs/test.py                            |  6 +++++-
 lms/templates/main_django.html              | 16 ++++++++--------
 lms/templates/wiki/base.html                |  4 ++--
 lms/templates/wiki/preview_inline.html      |  6 +++---
 requirements/edx/github.txt                 |  2 +-
 15 files changed, 39 insertions(+), 23 deletions(-)

diff --git a/cms/envs/acceptance.py b/cms/envs/acceptance.py
index 242463a..92e5dec 100644
--- a/cms/envs/acceptance.py
+++ b/cms/envs/acceptance.py
@@ -127,3 +127,7 @@ YOUTUBE['TEXT_API']['url'] = "127.0.0.1:{0}/test_transcripts_youtube/".format(YO
 # Generate a random UUID so that different runs of acceptance tests don't break each other
 import uuid
 SECRET_KEY = uuid.uuid4().hex
+
+############################### PIPELINE #######################################
+
+PIPELINE_ENABLED = False
diff --git a/cms/envs/common.py b/cms/envs/common.py
index 3c34b14..fb05659 100644
--- a/cms/envs/common.py
+++ b/cms/envs/common.py
@@ -458,6 +458,8 @@ EMBARGO_SITE_REDIRECT_URL = None
 
 ############################### PIPELINE #######################################
 
+PIPELINE_ENABLED = True
+
 # Process static files using RequireJS Optimizer
 STATICFILES_STORAGE = 'openedx.core.lib.django_require.staticstorage.OptimizedCachedRequireJsStorage'
 
diff --git a/cms/envs/devstack.py b/cms/envs/devstack.py
index bd00323..8abcaf1 100644
--- a/cms/envs/devstack.py
+++ b/cms/envs/devstack.py
@@ -34,6 +34,7 @@ FEATURES['PREVIEW_LMS_BASE'] = "preview." + LMS_BASE
 ########################### PIPELINE #################################
 
 # Skip packaging and optimization in development
+PIPELINE_ENABLED = False
 STATICFILES_STORAGE = 'pipeline.storage.NonPackagingPipelineStorage'
 
 # Revert to the default set of finders as we don't want the production pipeline
diff --git a/cms/envs/test.py b/cms/envs/test.py
index 343b7f3..8de6e8e 100644
--- a/cms/envs/test.py
+++ b/cms/envs/test.py
@@ -92,7 +92,6 @@ STATICFILES_DIRS += [
 # http://stackoverflow.com/questions/12816941/unit-testing-with-django-pipeline
 STATICFILES_STORAGE = 'pipeline.storage.NonPackagingPipelineStorage'
 STATIC_URL = "/static/"
-PIPELINE_ENABLED = False
 
 # Update module store settings per defaults for tests
 update_module_store_settings(
diff --git a/common/djangoapps/pipeline_mako/__init__.py b/common/djangoapps/pipeline_mako/__init__.py
index 97c17b6..c134da9 100644
--- a/common/djangoapps/pipeline_mako/__init__.py
+++ b/common/djangoapps/pipeline_mako/__init__.py
@@ -14,7 +14,7 @@ def compressed_css(package_name, raw=False):
 
     package = packager.package_for('css', package_name)
 
-    if settings.PIPELINE:
+    if settings.PIPELINE_ENABLED:
         return render_css(package, package.output_filename, raw=raw)
     else:
         paths = packager.compile(package.paths)
@@ -48,7 +48,7 @@ def compressed_js(package_name):
 
     package = packager.package_for('js', package_name)
 
-    if settings.PIPELINE:
+    if settings.PIPELINE_ENABLED:
         return render_js(package, package.output_filename)
     else:
         paths = packager.compile(package.paths)
diff --git a/lms/envs/acceptance.py b/lms/envs/acceptance.py
index 53fae64..75f9cbe 100644
--- a/lms/envs/acceptance.py
+++ b/lms/envs/acceptance.py
@@ -190,3 +190,7 @@ if FEATURES.get('ENABLE_COURSEWARE_SEARCH') or \
 # Generate a random UUID so that different runs of acceptance tests don't break each other
 import uuid
 SECRET_KEY = uuid.uuid4().hex
+
+############################### PIPELINE #######################################
+
+PIPELINE_ENABLED = False
diff --git a/lms/envs/aws.py b/lms/envs/aws.py
index 62c29bc..621e32f 100644
--- a/lms/envs/aws.py
+++ b/lms/envs/aws.py
@@ -131,9 +131,6 @@ if STATIC_URL_BASE:
     if not STATIC_URL.endswith("/"):
         STATIC_URL += "/"
 
-# Enable uglification of JavaScript
-PIPELINE_JS_COMPRESSOR = 'pipeline.compressors.uglifyjs.UglifyJSCompressor'
-
 # DEFAULT_COURSE_ABOUT_IMAGE_URL specifies the default image to show for courses that don't provide one
 DEFAULT_COURSE_ABOUT_IMAGE_URL = ENV_TOKENS.get('DEFAULT_COURSE_ABOUT_IMAGE_URL', DEFAULT_COURSE_ABOUT_IMAGE_URL)
 
diff --git a/lms/envs/bok_choy.py b/lms/envs/bok_choy.py
index c411550..ac6a5fe 100644
--- a/lms/envs/bok_choy.py
+++ b/lms/envs/bok_choy.py
@@ -74,6 +74,9 @@ DEFAULT_FILE_STORAGE = 'django.core.files.storage.FileSystemStorage'
 MEDIA_ROOT = TEST_ROOT / "uploads"
 MEDIA_URL = "/static/uploads/"
 
+# Don't use compression during tests
+PIPELINE_JS_COMPRESSOR = None
+
 ################################# CELERY ######################################
 
 CELERY_ALWAYS_EAGER = True
diff --git a/lms/envs/common.py b/lms/envs/common.py
index bd4b56d..90c3c29 100644
--- a/lms/envs/common.py
+++ b/lms/envs/common.py
@@ -1195,6 +1195,8 @@ X_FRAME_OPTIONS = 'ALLOW'
 
 ############################### PIPELINE #######################################
 
+PIPELINE_ENABLED = True
+
 # Process static files using RequireJS Optimizer
 STATICFILES_STORAGE = 'openedx.core.lib.django_require.staticstorage.OptimizedCachedRequireJsStorage'
 
@@ -1206,9 +1208,8 @@ STATICFILES_FINDERS = [
     'pipeline.finders.PipelineFinder',
 ]
 
-# Don't use compression by default
 PIPELINE_CSS_COMPRESSOR = None
-PIPELINE_JS_COMPRESSOR = None
+PIPELINE_JS_COMPRESSOR = 'pipeline.compressors.uglifyjs.UglifyJSCompressor'
 
 # Setting that will only affect the edX version of django-pipeline until our changes are merged upstream
 PIPELINE_COMPILE_INPLACE = True
diff --git a/lms/envs/devstack.py b/lms/envs/devstack.py
index 34899a8..43fe370 100644
--- a/lms/envs/devstack.py
+++ b/lms/envs/devstack.py
@@ -86,6 +86,7 @@ def should_show_debug_toolbar(_):
 ########################### PIPELINE #################################
 
 # Skip packaging and optimization in development
+PIPELINE_ENABLED = False
 STATICFILES_STORAGE = 'pipeline.storage.NonPackagingPipelineStorage'
 
 # Revert to the default set of finders as we don't want the production pipeline
diff --git a/lms/envs/test.py b/lms/envs/test.py
index c695f77..0ed5986 100644
--- a/lms/envs/test.py
+++ b/lms/envs/test.py
@@ -129,6 +129,8 @@ XQUEUE_WAITTIME_BETWEEN_REQUESTS = 5  # seconds
 MOCK_STAFF_GRADING = True
 MOCK_PEER_GRADING = True
 
+############################ STATIC FILES #############################
+
 # TODO (cpennington): We need to figure out how envs/test.py can inject things
 # into common.py so that we don't have to repeat this sort of thing
 STATICFILES_DIRS = [
@@ -146,7 +148,9 @@ STATICFILES_DIRS += [
 # find pipelined assets will raise a ValueError.
 # http://stackoverflow.com/questions/12816941/unit-testing-with-django-pipeline
 STATICFILES_STORAGE = 'pipeline.storage.NonPackagingPipelineStorage'
-PIPELINE_ENABLED = False
+
+# Don't use compression during tests
+PIPELINE_JS_COMPRESSOR = None
 
 update_module_store_settings(
     MODULESTORE,
diff --git a/lms/templates/main_django.html b/lms/templates/main_django.html
index 457dd67..c8d2aac 100644
--- a/lms/templates/main_django.html
+++ b/lms/templates/main_django.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-{% load compressed %}
+{% load pipeline %}
 {% load sekizai_tags i18n microsite %}
 {% load url from future %}
 {% load staticfiles %}
@@ -10,13 +10,13 @@
 
  <link rel="icon" type="image/x-icon" href="{% favicon_path %}" />
 
-  {% compressed_css 'style-vendor' %}
-  {% compressed_css 'style-main' %}
-  {% compressed_css 'style-course-vendor' %}
-  {% compressed_css 'style-course' %}
+  {% stylesheet 'style-vendor' %}
+  {% stylesheet 'style-main' %}
+  {% stylesheet 'style-course-vendor' %}
+  {% stylesheet 'style-course' %}
 
   {% block main_vendor_js %}
-  {% compressed_js 'main_vendor' %}
+  {% javascript 'main_vendor' %}
   {% endblock %}
   {% block headextra %}{% endblock %}
   {% render_block "css" %}
@@ -50,8 +50,8 @@
 
   </div>
 
-    {% compressed_js 'application' %}
-    {% compressed_js 'module-js' %}
+    {% javascript 'application' %}
+    {% javascript 'module-js' %}
 
     {% render_block "js" %}
 </body>
diff --git a/lms/templates/wiki/base.html b/lms/templates/wiki/base.html
index 7191443..f64206f 100644
--- a/lms/templates/wiki/base.html
+++ b/lms/templates/wiki/base.html
@@ -1,5 +1,5 @@
 {% extends "main_django.html" %}
-{% load compressed %}{% load sekizai_tags i18n microsite %}{% load url from future %}{% load staticfiles %}
+{% load pipeline %}{% load sekizai_tags i18n microsite %}{% load url from future %}{% load staticfiles %}
 
 {% block title %}<title>{% block pagetitle %}{% endblock %} | {% trans "Wiki" %} | {% platform_name %}</title>{% endblock %}
 
@@ -7,7 +7,7 @@
 
 {% block headextra %}
   <script type="text/javascript" src="/i18n.js"></script>
-  {% compressed_css 'course' %}
+  {% stylesheet 'course' %}
 
   <script type="text/javascript">
     function ajaxError(){}
diff --git a/lms/templates/wiki/preview_inline.html b/lms/templates/wiki/preview_inline.html
index decd185..67e2623 100644
--- a/lms/templates/wiki/preview_inline.html
+++ b/lms/templates/wiki/preview_inline.html
@@ -1,9 +1,9 @@
 <!DOCTYPE html>
-{% load wiki_tags i18n %}{% load compressed %}
+{% load wiki_tags i18n %}{% load pipeline %}
 <html lang="{{LANGUAGE_CODE}}">
 <head>
-  {% compressed_css 'course' %}  
-  {% compressed_js 'main_vendor' %}
+  {% stylesheet 'course' %}
+  {% javascript 'main_vendor' %}
 </head>
 <body class="modal-preview">
   <section class="container wiki view">
diff --git a/requirements/edx/github.txt b/requirements/edx/github.txt
index 1135437..3849113 100644
--- a/requirements/edx/github.txt
+++ b/requirements/edx/github.txt
@@ -9,7 +9,7 @@
 
 # Third-party:
 git+https://github.com/edx/django-staticfiles.git@031bdeaea85798b8c284e2a09977df3e32d06b5d#egg=django-staticfiles==1.2.1.0003
--e git+https://github.com/edx/django-pipeline.git@88ec8a011e481918fdc9d2682d4017c835acd8be#egg=django-pipeline
+-e git+https://github.com/edx/django-pipeline.git@1.5.3+importfixes#egg=django-pipeline
 -e git+https://github.com/edx/django-wiki.git@cd0b2b31997afccde519fe5b3365e61a9edb143f#egg=django-wiki
 -e git+https://github.com/edx/django-oauth2-provider.git@0.2.7-fork-edx-5#egg=django-oauth2-provider
 -e git+https://github.com/edx/django-rest-framework-oauth.git@f0b503fda8c254a38f97fef802ded4f5fe367f7a#egg=djangorestframework-oauth
--
libgit2 0.26.0