Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
95b2b828
Commit
95b2b828
authored
May 02, 2015
by
Ahsan Ulhaq
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Forums vote tracking missing spaces causes awkward reading
AC-102
parent
bfb201ec
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
common/static/coffee/spec/discussion/view/discussion_view_spec_helper.coffee
+1
-1
common/static/coffee/src/discussion/views/discussion_content_view.coffee
+1
-1
lms/templates/discussion/_underscore_templates.html
+1
-1
No files found.
common/static/coffee/spec/discussion/view/discussion_view_spec_helper.coffee
View file @
95b2b828
...
@@ -22,7 +22,7 @@ class @DiscussionViewSpecHelper
...
@@ -22,7 +22,7 @@ class @DiscussionViewSpecHelper
expect
(
button
.
hasClass
(
"is-checked"
)).
toBe
(
user
.
voted
(
model
))
expect
(
button
.
hasClass
(
"is-checked"
)).
toBe
(
user
.
voted
(
model
))
expect
(
button
.
attr
(
"aria-checked"
)).
toEqual
(
user
.
voted
(
model
).
toString
())
expect
(
button
.
attr
(
"aria-checked"
)).
toEqual
(
user
.
voted
(
model
).
toString
())
expect
(
button
.
find
(
".vote-count"
).
text
()).
toMatch
(
"^
#{
model
.
get
(
'votes'
).
up_count
}
Votes?$"
)
expect
(
button
.
find
(
".vote-count"
).
text
()).
toMatch
(
"^
#{
model
.
get
(
'votes'
).
up_count
}
Votes?$"
)
expect
(
button
.
find
(
".sr.js-sr-vote-count"
).
text
()).
toMatch
(
"^currently
#{
model
.
get
(
'votes'
).
up_count
}
votes?$"
)
expect
(
button
.
find
(
".sr.js-sr-vote-count"
).
text
()).
toMatch
(
"^
there are
currently
#{
model
.
get
(
'votes'
).
up_count
}
votes?$"
)
@
checkRenderVote
=
(
view
,
model
)
->
@
checkRenderVote
=
(
view
,
model
)
->
view
.
render
()
view
.
render
()
...
...
common/static/coffee/src/discussion/views/discussion_content_view.coffee
View file @
95b2b828
...
@@ -113,7 +113,7 @@ if Backbone?
...
@@ -113,7 +113,7 @@ if Backbone?
numVotes
=
votes
.
up_count
numVotes
=
votes
.
up_count
button
.
find
(
".js-sr-vote-count"
).
html
(
button
.
find
(
".js-sr-vote-count"
).
html
(
interpolate
(
interpolate
(
ngettext
(
"
currently %(numVotes)s vote"
,
"
currently %(numVotes)s votes"
,
numVotes
),
ngettext
(
"
there is currently %(numVotes)s vote"
,
"there are
currently %(numVotes)s votes"
,
numVotes
),
{
numVotes
:
numVotes
},
{
numVotes
:
numVotes
},
true
true
)
)
...
...
lms/templates/discussion/_underscore_templates.html
View file @
95b2b828
...
@@ -525,7 +525,7 @@ ${primaryAction("follow", "star", _("Follow"), _("Follow"), _("Unfollow"))}
...
@@ -525,7 +525,7 @@ ${primaryAction("follow", "star", _("Follow"), _("Follow"), _("Unfollow"))}
<
/span
>
<
/span
>
<
a
href
=
"#"
class
=
"action-button action-vote"
role
=
"checkbox"
aria
-
checked
=
"false"
>
<
a
href
=
"#"
class
=
"action-button action-vote"
role
=
"checkbox"
aria
-
checked
=
"false"
>
##
Vote
counts
are
populated
by
JS
##
Vote
counts
are
populated
by
JS
<
span
class
=
"sr"
>
$
{
_
(
"Vote
"
)}
<
/span
>
<
span
class
=
"sr"
>
$
{
_
(
"Vote
for this post,"
)}
&
nbsp
;
<
/span
>
<
span
class
=
"sr js-sr-vote-count"
><
/span
>
<
span
class
=
"sr js-sr-vote-count"
><
/span
>
<
span
class
=
"action-label"
aria
-
hidden
=
"true"
>
<
span
class
=
"action-label"
aria
-
hidden
=
"true"
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment