Skip to content

E
edx-platform
Commit 9064f81b by Arjun Singh
Options

minor sidebar fix

parent 2ca51f06
Showing with 7 additions and 6 deletions
lms/static/js/discussions-temp.js
...@@ -348,15 +348,16 @@ function updateSidebarDimensions(e) { ...@@ -348,15 +348,16 @@ function updateSidebarDimensions(e) {
discussionColumnHeight = $('.discussion-column').outerHeight(); discussionColumnHeight = $('.discussion-column').outerHeight();
discussionColumnBottom = $('.discussion-column').offset().top + discussionColumnHeight; discussionColumnBottom = $('.discussion-column').offset().top + discussionColumnHeight;
windowHeight = $(window).height(); windowHeight = $(window).height();
$('.sidebar').height(discussionColumnHeight); sidebarHeight = Math.min(windowHeight, discussionColumnHeight);
$('.post-list-wrapper').height(discussionColumnHeight - SIDEBAR_HEADER_HEIGHT - 4); $('.sidebar').height(sidebarHeight);
$('.post-list-wrapper').height(sidebarHeight - SIDEBAR_HEADER_HEIGHT - 4);
$('.sidebar').css('width', .32 * $('.discussion-body').width() + 'px'); $('.sidebar').css('width', .32 * $('.discussion-body').width() + 'px');
//$('.sidebar').height(discussionColumnBottom - scrollTop); //$('.sidebar').height(discussionColumnBottom - scrollTop);
//$('.post-list-wrapper').height(discussionColumnBottom - scrollTop - SIDEBAR_HEADER_HEIGHT - 4); //$('.post-list-wrapper').height(discussionColumnBottom - scrollTop - SIDEBAR_HEADER_HEIGHT - 4);
//if((discussionColumnBottom - scrollTop) < windowHeight){ if((discussionColumnBottom - scrollTop) < windowHeight){
// $('.sidebar').height(discussionColumnHeight); $('.sidebar').height(discussionColumnHeight);
// $('.post-list-wrapper').height(discussionColumnHeight - SIDEBAR_HEADER_HEIGHT - 4); $('.post-list-wrapper').height(discussionColumnHeight - SIDEBAR_HEADER_HEIGHT - 4);
//} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment