Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
8231d2d0
Commit
8231d2d0
authored
May 08, 2017
by
Diana Huang
Committed by
GitHub
May 08, 2017
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #15058 from edx/diana/course-date-info-fix
Only try to render dates when user is authenticated.
parents
15b11141
c0b7f9b8
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
2 deletions
+9
-2
lms/djangoapps/courseware/tests/test_date_summary.py
+7
-0
lms/djangoapps/courseware/views/views.py
+2
-2
No files found.
lms/djangoapps/courseware/tests/test_date_summary.py
View file @
8231d2d0
...
...
@@ -96,10 +96,17 @@ class CourseDateSummaryTest(SharedModuleStoreTestCase):
def
test_course_info_feature_flag
(
self
):
SelfPacedConfiguration
(
enable_course_home_improvements
=
False
)
.
save
()
self
.
setup_course_and_user
()
self
.
client
.
login
(
username
=
'mrrobot'
,
password
=
'test'
)
url
=
reverse
(
'info'
,
args
=
(
self
.
course
.
id
,))
response
=
self
.
client
.
get
(
url
)
self
.
assertNotIn
(
'date-summary'
,
response
.
content
)
def
test_course_info_logged_out
(
self
):
self
.
setup_course_and_user
()
url
=
reverse
(
'info'
,
args
=
(
self
.
course
.
id
,))
response
=
self
.
client
.
get
(
url
)
self
.
assertEqual
(
200
,
response
.
status_code
)
# Tests for which blocks are enabled
def
assert_block_types
(
self
,
expected_blocks
):
"""Assert that the enabled block types for this course are as expected."""
...
...
lms/djangoapps/courseware/views/views.py
View file @
8231d2d0
...
...
@@ -334,10 +334,10 @@ def course_info(request, course_id):
# Construct the dates fragment
dates_fragment
=
None
if
SelfPacedConfiguration
.
current
()
.
enable_course_home_improvements
:
dates_fragment
=
CourseDatesFragmentView
()
.
render_to_fragment
(
request
,
course_id
=
course_id
)
if
request
.
user
.
is_authenticated
():
if
SelfPacedConfiguration
.
current
()
.
enable_course_home_improvements
:
dates_fragment
=
CourseDatesFragmentView
()
.
render_to_fragment
(
request
,
course_id
=
course_id
)
show_upgrade_notification
=
False
if
request
.
GET
.
get
(
'upgrade'
,
'false'
)
==
'true'
:
store_upgrade_cookie
=
True
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment