slight refactoring of the javascript

cms/static/js/base.js

@@ -233,30 +233,33 @@ function showFileSelectionMenu(e) {
 function startUpload(e) {
     $('.upload-modal h1').html('Uploading…');
     $('.upload-modal .file-name').html($('.file-input').val());
-
-    var bar = $('.upload-modal .progress-fill');
-
     $('.upload-modal .file-chooser').ajaxSubmit({
-        beforeSend: function() {
+        beforeSend: resetUploadBar,
+        uploadProgress: showUploadFeedback,
+        complete: displayFinishedUpload
+    });
+    $('.upload-modal .choose-file-button').hide();
+    $('.upload-modal .progress-bar').removeClass('loaded').show();
+}
+
+function resetUploadBar(){
     var percentVal = '0%';
-            bar.width(percentVal)
-            bar.html(percentVal);
-        },
-        uploadProgress: function(event, position, total, percentComplete) {
+    $('.upload-modal .progress-fill').width(percentVal)
+    $('.upload-modal .progress-fill').html(percentVal);
+}
+
+function showUploadFeedback(event, position, total, percentComplete) {
     var percentVal = percentComplete + '%';
-            bar.width(percentVal)
-            bar.html(percentVal);
-        },
-        complete: function(xhr) {
+    $('.upload-modal .progress-fill').width(percentVal);
+    $('.upload-modal .progress-fill').html(percentVal);
+}
+
+function displayFinishedUpload(xhr) {
     if(xhr.status = 200){
         markAsLoaded();
     }
-            bar.html(xhr.responseText);
+    $('.upload-modal .progress-fill').html(xhr.responseText);
     $('.upload-modal .choose-file-button').html('Load Another File').show();
-        }
-    });
-    $('.upload-modal .choose-file-button').hide();
-    $('.upload-modal .progress-bar').removeClass('loaded').show();
 }
 
 function markAsLoaded() {