Fix `withData` and `withConfiguration` helpers.

Both of them dynamically generate specs which close over the iteration
variable of a for loop. Closures capture *references*, not values, and
so when the variable is mutated on loop iteration its new value is
used when the spec is called. This means that instead of running a
spec with n different values, we run the spec n times with the same
value. This is bad.

common/static/common/js/spec_helpers/spec_helpers.js

@@ -13,9 +13,11 @@ define([], function () {
     var withData = function (data, func) {
         for (var name in data) {
             if (data.hasOwnProperty(name)) {
+                (function (name) {
                     it(name, function () {
                         func.apply(this, data[name]);
                     });
+                })(name);
             }
         }
     };
@@ -31,12 +33,14 @@ define([], function () {
     var withConfiguration = function (config, setup, test) {
         for (var name in config) {
             if (config.hasOwnProperty(name)) {
+                (function (name) {
                     describe(name, function () {
                         beforeEach(function () {
                             setup.apply(this, config[name]);
                         });
                         test();
                     });
+                })(name);
             }
         }
     };

lms/djangoapps/teams/static/teams/js/spec/views/teams_tab_spec.js

@@ -173,8 +173,9 @@ define([
                 var teamsTabView = createTeamsTabView(this, {
                     userInfo: TeamSpecHelpers.createMockUserInfo({staff: true})
                 });
+                teamsTabView.teamsCollection = TeamSpecHelpers.createMockTeams();
                 teamsTabView.router.navigate(url, {trigger: true});
-                if (AjaxHelpers.currentRequest(requests)) {
+                if (requests.length > requests.currentIndex) {
                     AjaxHelpers.respondWithJson(requests, {});
                 }
                 expect(Logger.log).toHaveBeenCalledWith('edx.team.page_viewed', expectedEvent);