Skip to content

E
edx-platform
Commit 598922b4 by Don Mitchell
Options

Dont' warn about name change on initial creation. 

Fixed overview to save correctly (not overwrite w/ old value)
parent f7703dad
Showing with 2 additions and 2 deletions
cms/static/js/views/settings/main_settings_view.js
......@@ -50,11 +50,11 @@ CMS.Views.ValidatingView = Backbone.View.extend({
saveIfChanged : function(event) {
// returns true if the value changed and was thus sent to server
this.clearValidationErrors();
var field = this.selectorToField[event.currentTarget.id];
var currentVal = this.model.get(field);
var newVal = $(event.currentTarget).val();
if (currentVal != newVal) {
this.clearValidationErrors();
this.model.save(field, newVal);
return true;
}
......@@ -645,7 +645,7 @@ CMS.Views.Settings.GraderView = CMS.Views.ValidatingView.extend({
break;
case 'course-grading-assignment-name':
var oldName = this.model.get('type');
if (this.saveIfChanged(event)) {
if (this.saveIfChanged(event) && !_.isEmpty(oldName)) {
// overload the error display logic
this._cacheValidationErrors.push(event.currentTarget);
$(event.currentTarget).parent().append(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment