Merge pull request #16169 from edx/robrap/LEARNER-2026-fix-bug

LEARNER-2026: Fix upgrade event.

lms/static/js/dashboard/legacy.js

@@ -43,6 +43,11 @@
         // a `track` call whenever a bound link is clicked. Usually the page would change before
         // `track` had time to execute; `trackLink` inserts a small timeout to give the `track`
         // call enough time to fire. The clicked link element is passed to `generateProperties`.
+        // NOTE: This is a duplicate of the 'edx.course.enrollment.upgrade.clicked' event with
+        //  location learner_dashboard.  This bi event is being left in for now because:
+        //  1. I don't know who is relying on it and it is viewable separately in GA.
+        //  2. The other event doesn't yet have the benefit of the timeout of trackLink(), so
+        //     the other event might under-report as compared to this event.
          window.analytics.trackLink(upgradeButtonLinks, 'edx.bi.dashboard.upgrade_button.clicked', generateProperties);
 
         // Track clicks of the "verify now" button.
@@ -116,11 +121,8 @@
              $('#failed-verification-banner').addClass('is-hidden');
          });
 
-         $('#upgrade-to-verified').click(function(event) {
-             var user = $(event.target).closest('.action-upgrade').data('user'),
-                 course = $(event.target).closest('.action-upgrade').data('course-id');
-
-             Logger.log('edx.course.enrollment.upgrade.clicked', [user, course], {location: 'learner_dashboard'});
+         $('.action-upgrade').click(function() {
+             Logger.log('edx.course.enrollment.upgrade.clicked', {location: 'learner_dashboard'});
          });
 
          $('.action-email-settings').click(function(event) {