Merge pull request #509 from MITx/feature/victor/better-courseware-errors

Feature/victor/better courseware errors

common/djangoapps/xmodule_modifiers.py

@@ -112,6 +112,9 @@ def add_histogram(get_html, module, user):
             edit_link = "%s/%s/tree/master/%s" % (giturl,data_dir,filepath)
         else:
             edit_link = False
+            # Need to define all the variables that are about to be used
+            giturl = ""
+            data_dir = ""
         source_file = module.metadata.get('source_file','')	# source used to generate the problem XML, eg latex or word
 
         staff_context = {'definition': module.definition.get('data'),

lms/djangoapps/courseware/views.py

@@ -187,7 +187,10 @@ def index(request, course_id, chapter=None, section=None,
                                             {'staff_access': staff_access,
                                             'course' : course})
             except:
-                result = HttpResponse("There was an unrecoverable error")
+                # Let the exception propagate, relying on global config to at
+                # at least return a nice error message
+                log.exception("Error while rendering courseware-error page")
+                raise
 
     return result